Skip to content

Commit 5b360f3

Browse files
committed
remove unused field 'pskb' in struct trace
'pskb' is not needed anymore, we can remove it now. Signed-off-by: Menglong Dong <imagedong@tencent.com>
1 parent a534e3e commit 5b360f3

3 files changed

Lines changed: 2 additions & 8 deletions

File tree

legacy/nettrace.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def is_ret_enabled(tracer):
5050
def is_valid(tracer):
5151
if Tracer.is_tp(tracer):
5252
return True
53-
if 'skb' not in tracer and 'pskb' not in tracer:
53+
if 'skb' not in tracer:
5454
return False
5555
return True
5656

@@ -262,10 +262,6 @@ def _generate_tracer_code(tracer, index):
262262
pad_index = tracer['skb']
263263
skb_param = 'struct sk_buff *skb'
264264
bpf_prep = ''
265-
elif 'pskb' in tracer:
266-
pad_index = tracer['pskb']
267-
skb_param = 'struct sk_buff **pskb'
268-
bpf_prep = 'struct sk_buff *skb = *pskb;'
269265
else:
270266
return
271267

legacy/skb.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ children:
2020
- name: __netif_receive_skb_core
2121
skb: 0
2222
if: kernelVersion < 504
23-
- name: __netif_receive_skb_core
24-
pskb: 0
23+
- name: __netif_receive_skb_core_pskb
2524
if: kernelVersion >= 504
2625
- name: link-out
2726
desc: link layer (L2) of packet out

src/trace.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ typedef struct trace {
4444
char *regex;
4545
char *tp;
4646
int skb;
47-
int pskb;
4847
struct list_head sibling;
4948
struct list_head list;
5049
struct list_head rules;

0 commit comments

Comments
 (0)