Collection Reference cascade without code or any filter (against full repo) is not allowed for now

Author: snyaggarwal

core/collections/models.py

@@ -748,7 +748,7 @@ def generate_references(self):
         return references
 
     def should_generate_multiple_references(self):
-        return self.include and self.cascade and self.transform
+        return self.include and self.cascade and self.transform and self.code
 
     @staticmethod
     def transform_to_latest_version(queryset, klass):
@@ -931,6 +931,10 @@ def clean(self):
         if not self.is_valid_filter():
             raise ValidationError({'filter': ['Invalid filter schema.']})
 
+        if not self.is_valid_cascade():
+            raise ValidationError(
+                {'cascade': ['Invalid cascade schema. Either "code" or "filter" must be provided']})
+
         self.original_expression = str(self.expression)
         if not self.is_static_transform and not self.is_extensional_transform:
             self.transform = None
@@ -957,6 +961,13 @@ def filter_to_querystring(self):
             return '&'.join(queries)
         return None
 
+    def is_valid_cascade(self):
+        if not self.cascade:
+            return True
+        if self.cascade and not (self.code or self.filter):
+            return False
+        return True
+
     def is_valid_filter(self):
         if not self.filter:
             return True

core/integration_tests/tests_collections.py

@@ -962,6 +962,37 @@ def test_put_expression_with_cascade_to_concepts(self):
             ])
         )
 
+        random_concept = ConceptFactory()
+
+        response = self.client.put(
+            self.collection.uri + 'references/?transformReferences=extensional',
+            {
+                'data': {'expression': random_concept.parent.uri},
+                'cascade': {
+                    'method': 'sourcetoconcepts',
+                    'cascade levels': '*',
+                    'map types': 'Q AND A,CONCEPT SET',
+                    'return map types': '*'
+                }
+            },
+            HTTP_AUTHORIZATION='Token ' + self.token,
+            format='json'
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(
+            response.data,
+            [{
+                 'added': False,
+                 'expression': random_concept.parent.uri,
+                 'message': [
+                     'This field cannot be null.',
+                     'Invalid cascade schema. Either "code" or "filter" must be provided'
+                 ]
+             }]
+        )
+
+
     def test_put_expression_transform_to_latest_version(self):
         concept2 = ConceptFactory()
         concept2_latest_version = concept2.get_latest_version()