Limiting locales for each concept to max 500

Author: snyaggarwal

core/concepts/constants.py

@@ -25,6 +25,9 @@
 OPENMRS_CONCEPT_CLASS = 'Invalid concept class'
 BASIC_DESCRIPTION_CANNOT_BE_EMPTY = 'Concept description cannot be empty'
 BASIC_NAMES_CANNOT_BE_EMPTY = 'A concept must have at least one name'
+MAX_LOCALES_LIMIT = 500
+MAX_NAMES_LIMIT = 'max limit {} of names exceeded'.format(MAX_LOCALES_LIMIT)
+MAX_DESCRIPTIONS_LIMIT = 'max limit {} of descriptions exceeded'.format(MAX_LOCALES_LIMIT)
 CONCEPT_WAS_RETIRED = 'Concept was retired'
 CONCEPT_WAS_UNRETIRED = 'Concept was un-retired'
 CONCEPT_IS_ALREADY_RETIRED = 'Concept is already retired'

core/concepts/models.py

@@ -14,7 +14,8 @@
     encode_string, decode_string
 from core.concepts.constants import CONCEPT_TYPE, LOCALES_FULLY_SPECIFIED, LOCALES_SHORT, LOCALES_SEARCH_INDEX_TERM, \
     CONCEPT_WAS_RETIRED, CONCEPT_IS_ALREADY_RETIRED, CONCEPT_IS_ALREADY_NOT_RETIRED, CONCEPT_WAS_UNRETIRED, \
-    PERSIST_CLONE_ERROR, PERSIST_CLONE_SPECIFY_USER_ERROR, ALREADY_EXISTS, CONCEPT_REGEX
+    PERSIST_CLONE_ERROR, PERSIST_CLONE_SPECIFY_USER_ERROR, ALREADY_EXISTS, CONCEPT_REGEX, MAX_LOCALES_LIMIT, \
+    MAX_NAMES_LIMIT, MAX_DESCRIPTIONS_LIMIT
 from core.concepts.mixins import ConceptValidationMixin
 
 
@@ -548,6 +549,7 @@ def persist_new(cls, data, user=None, create_initial_version=True, create_parent
             return concept
 
         try:
+            concept.validate_locales_limit(names, descriptions)
             concept.cloned_names = names
             concept.cloned_descriptions = descriptions
             concept.full_clean()
@@ -615,6 +617,8 @@ def persist_clone(
         prev_latest_version = versioned_object.versions.exclude(id=obj.id).filter(is_latest_version=True).first()
         try:
             with transaction.atomic():
+                cls.validate_locales_limit(obj.cloned_names, obj.cloned_descriptions)
+
                 cls.pause_indexing()
 
                 obj.is_latest_version = True
@@ -666,6 +670,13 @@ def index_all():
 
         return errors
 
+    @staticmethod
+    def validate_locales_limit(names, descriptions):
+        if len(names) > MAX_LOCALES_LIMIT:
+            raise ValidationError({'names': [MAX_NAMES_LIMIT]})
+        if len(descriptions) > MAX_LOCALES_LIMIT:
+            raise ValidationError({'descriptions': [MAX_DESCRIPTIONS_LIMIT]})
+
     def get_unidirectional_mappings_for_collection(self, collection_url, collection_version=HEAD):
         from core.mappings.models import Mapping
         return Mapping.objects.filter(