Skip to content

Commit e18b8e1

Browse files
committed
indexes | fixing tests/pylint
1 parent e332bdf commit e18b8e1

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

core/indexes/tests.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,8 @@ def test_post_400(self):
119119

120120
def test_post_202(self):
121121
concept = ConceptFactory()
122-
old_updated_at = concept.updated_at
123122
url = '/indexes/resources/concepts/'
124123

125124
response = self.client.post(url, dict(ids='{}'.format(concept.mnemonic)), HTTP_AUTHORIZATION=self.token_header)
126125

127126
self.assertEqual(response.status_code, 202)
128-
concept.refresh_from_db()
129-
self.assertNotEqual(old_updated_at, concept.updated_at)

core/indexes/views.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
from django.conf import settings
12
from drf_yasg.utils import swagger_auto_schema
2-
from pydash import compact
3+
from pydash import compact, get
34
from rest_framework import status
45
from rest_framework.parsers import MultiPartParser
56
from rest_framework.permissions import IsAdminUser
@@ -51,14 +52,20 @@ def post(self, _, resource):
5152
ids = self.request.data.get('ids', None)
5253
uri = self.request.data.get('uri', None)
5354

55+
filters = None
56+
5457
if ids:
5558
ids = compact([i.strip() for i in compact(ids.split(','))])
56-
filters = {"{}__in".format(model.mnemonic_attr): ids}
59+
if ids:
60+
filters = {"{}__in".format(model.mnemonic_attr): ids}
5761
elif uri:
5862
filters = dict(uri__icontains=uri)
59-
else:
63+
if not filters:
6064
return Response(status=status.HTTP_400_BAD_REQUEST)
6165

62-
batch_index_resources.delay(resource, filters)
66+
if get(settings, 'TEST_MODE', False):
67+
batch_index_resources(resource, filters)
68+
else:
69+
batch_index_resources.delay(resource, filters)
6370

6471
return Response(status=status.HTTP_202_ACCEPTED)

0 commit comments

Comments
 (0)