From 581fba5bfdc81d5b5632947093c5f23c65552aa9 Mon Sep 17 00:00:00 2001
From: Val Alexander <68980965+BunsDev@users.noreply.github.com>
Date: Sat, 30 May 2026 19:36:47 -0500
Subject: [PATCH] fix(keymap): switch ToggleWarpDrive linux/windows binding off
 ctrl-b
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`ctrl-b` is the ASCII STX control character. Registering it on
Linux/Windows for the Workspace `ToggleWarpDrive` action failed
`is_binding_pty_compliant` validation at boot — `KeymapMatcher` then
panicked at `crates/warpui_core/src/keymap/matcher.rs:197` with
`Bindings failed validation`, taking out ~50+ integration tests
(`ui_tests::*`, shell-integration suites) that boot the test harness.

Switch to `ctrl-shift-B`, matching the `cmd_or_ctrl_shift` convention
for single-letter shortcuts that would otherwise collide with PTY
control characters on non-Mac platforms.

Verification:
- `cargo check -p warp-app` — passes
- `cargo test -p integration --test integration` — 211 passed, 8
  failed (all SSH / ctrl-c / vertical-context-menu — separate root
  causes, not keymap-related), 63 ignored. Was ~50+ tests panicking
  at the keymap validator before the fix.
---
 app/src/workspace/mod.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/src/workspace/mod.rs b/app/src/workspace/mod.rs
index bad611dd..df6ff359 100644
--- a/app/src/workspace/mod.rs
+++ b/app/src/workspace/mod.rs
@@ -704,7 +704,13 @@ pub fn init(app: &mut AppContext) {
         .with_context_predicate(id!("Workspace"))
         .with_custom_action(CustomAction::ToggleWarpDrive)
         .with_mac_key_binding("cmd-b")
-        .with_linux_or_windows_key_binding("ctrl-b"),
+        // `ctrl-b` is the ASCII STX control character — registering it on
+        // Linux/Windows trips `is_binding_pty_compliant` on the Workspace
+        // view and panics binding validation at boot. Use `ctrl-shift-B`,
+        // matching the convention `cmd_or_ctrl_shift` documents for
+        // single-letter Mac shortcuts that would otherwise collide with the
+        // PTY on non-Mac platforms.
+        .with_linux_or_windows_key_binding("ctrl-shift-B"),
         EditableBinding::new(
             TOGGLE_RIGHT_PANEL_BINDING_NAME,
             BindingDescription::new("Toggle code review")