Skip to content

Commit 93d1e33

Browse files
authored
feat: major editor overhaul (assets, properties, timeline, fonts) (#709)
* feat: major editor overhaul (assets, properties, timeline, fonts) Refactor editor core systems to standardize UI architecture and improve performance. Assets & Properties: - Replace monolithic property items with composable `Section` architecture. - Add specialized sections for Transform, Blending, and Text. - Implement `NumberField` with scrubbing and math evaluation. - Add new ColorPicker with EyeDropper and multiple format support. - Standardize asset panels using new `PanelView` layout. Fonts & Stickers: - Implement custom font atlas/sprite system for high-performance previews. - Add virtualized FontPicker with search and favorites. - Refactor stickers to use a provider-based architecture (icons, emoji, flags, shapes). - Standardize sticker IDs to `provider:value` format. Timeline & Interaction: - Convert bookmarks to rich objects with notes, colors, and duration. - Refactor drag-and-drop to use Command pattern (enabling proper undo/redo). - Add Shift modifier to disable snapping during moves/resizes. - Add new overlays for layout guides and text editing. Renderer: - Add support for multi-line text, custom line-height, and letter-spacing. - Implement global composite operation (blend modes). - Update sticker node to resolve dynamic provider IDs. Infrastructure: - Add storage migrations (v3->v6) for text weights, sticker IDs, and bookmarks. - Update global styles and core UI components (Button, Input, Popover). * add ts-nocheck directive to settings-legacy.tsx to suppress TypeScript errors * fix: correct global composite operation assignment in TextNode to ensure proper blend mode handling * deleted shadcn components with errors * formatting * fix linter issues * migrate from next middleware to proxy * add missing component back * add breadcrumb back * chore: add @radix-ui/react-primitive deps * chore: more deps * chore: add missing env vars to bun-ci * next env
1 parent fca99d6 commit 93d1e33

215 files changed

Lines changed: 26950 additions & 8334 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.cursor/commands/review.md

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Review every point below carefully to ensure files follow consistent code style
4949

5050
- [ ] Readability over brevity — use `element` not `el`, `event` not `e`
5151
- [ ] Booleans are named `isSomething`, `hasSomething`, or `shouldSomething` — not `something`
52-
- [ ] No title case in text/UI — use `Hello world` not `Hello World`
52+
- [ ] No title case for multi-word text/UI — use `Hello world` not `Hello World`
5353

5454
## Tailwind & Styling
5555

@@ -61,12 +61,15 @@ Review every point below carefully to ensure files follow consistent code style
6161
<PlusIcon className="!size-6" /> {/* ✅ correct */}
6262
<PlusIcon className="size-6" /> {/* ❌ wrong */}
6363
<PlusIcon className="!size-4" /> {/* ❌ unnecessary, size-4 is default */}
64+
<PlusIcon className="size-4" />{" "}
65+
{/* ❌ completely wrong, 1) doesn't override and 2) size-4 is default */}
6466
</Button>
6567
```
6668

6769
## State Management (Zustand)
6870

6971
- [ ] React components never use `someStore.getState()` — use the `useSomeStore` hook instead
72+
- [ ] High-frequency stores (timeline, playback, selections) use selectors — `useStore((s) => s.value)` not `const { value } = useStore()`
7073
- [ ] Store/manager methods are not passed as props — sub-components access them directly
7174

7275
```tsx
@@ -91,6 +94,11 @@ Review every point below carefully to ensure files follow consistent code style
9194

9295
- [ ] Code is scannable — use variables and helper functions to make intent clear at a glance
9396
- [ ] Complex logic is extracted into well-named variables or helpers
97+
- [ ] No magic numbers or magic values — extract inline literals into named constants
98+
- Applies to colors, durations, thresholds, sizes, config values, etc.
99+
- If it's domain-specific to one file, a `const` at the top of that file is fine
100+
- If it's generic enough, it belongs in `constants/`
101+
94102
- [ ] No redundant single/plural function variants — if a function can operate on multiple items, it should accept an array and handle both cases. Don't create `doThing()` + `doThings()`.
95103

96104
```tsx
@@ -116,4 +124,25 @@ Review every point below carefully to ensure files follow consistent code style
116124

117125
---
118126

119-
> Every decision, every edit must be carefully considered. Everything matters.
127+
## Review Methodology
128+
129+
Do NOT review by reading the file top-to-bottom and noting what jumps out. Instead:
130+
131+
1. Go through each checklist section **one at a time**
132+
2. For each section, scan the **entire file** for violations of that specific rule
133+
3. Only move to the next section after you've exhausted the current one
134+
4. After all sections are checked, do a final pass: re-read every checklist item and confirm you didn't skip it
135+
136+
Before outputting the table, list each checklist section and confirm you checked it:
137+
`Signatures ✓ | TypeScript ✓ | JSX ✓ | Organization ✓ | Comments ✓ | Naming ✓ | Tailwind ✓ | State ✓ | Quality ✓ | Keywords ✓`
138+
139+
---
140+
141+
## IMPORTANT: Review Rules
142+
143+
- **ONLY** flag issues that are explicitly covered by a checklist item above.
144+
- Do **NOT** invent your own rules, suggestions, or "nice to haves" as primary issues.
145+
- The review output must be a table of issues, each one mapping to a specific checklist item.
146+
- If something looks off but isn't covered by the checklist, you can mention it as a brief side note at the end — but keep it clearly separate from the actual review. Always default to fixing the issues covered by the checklist above, unless the user says otherwise.
147+
148+
> You WILL miss things if you try to review the whole file in one pass. Iterate rule by rule.

0 commit comments

Comments
 (0)