Skip to content

Legacy Deploy: keys change order in state #1364

@josephjclark

Description

@josephjclark

When using a v1 deploy and writing a state.json, the order of steps can change, resulting in huge diffs.

For example, here is a commit with a large diff - but the actual change was trivial. Since the key order has changed, it's impossible to compare the two diffs and see what changed.

In state v1 it might make sense to order steps by UUID (so that renaming a step also result in a small diff). Bit unintuitive but state.json isn't human readable so its fine.

I don't think I'll ever fix this. But I do want to be sure that this is stable in v2. Keys in project.yaml files should not change order.

Metadata

Metadata

Assignees

No one assigned

    Labels

    GH SyncRelated to Github sync improvementssync v2

    Type

    No type

    Projects

    Status

    New Issues

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions