Fix tests broken by Phoenix 1.8 and LiveView 1.1 upgrade

Phoenix 1.8 renders boolean HTML attributes as attr="" instead of
attr="attr". lazy_html (new LiveView 1.1 test dep) enforces stricter
CSS selector parsing than Floki. Changes:

- Replace disabled="disabled" / checked="checked" assertions with
  disabled="" / checked="" throughout
- Replace [attr='attr'] CSS selectors with presence-only [attr] selectors
- Fix malformed attribute selectors missing closing quotes that Floki
  accepted silently but lazy_html rejects (e.g. [id='...id])
- Fix comma-separated attributes in single brackets to chained brackets
  (e.g. [a='x', b='y'] -> [a='x'][b='y'])
- Replace tbody:first-child selectors (now semantically enforced by
  lazy_html) with tbody:first-of-type or scoped ID selectors
- Replace selected="selected" option assertions with selected=""
- Fix save_is_disabled? helper to use List.keymember? instead of
  checking for {"disabled", "disabled"} tuple
- Replace ErrorViewTest with tests for ErrorHTML and ErrorJSON,
  including integration tests that exercise the full request cycle

Author: midigofrank

test/lightning/workflow_versions_test.exs

@@ -6,7 +6,7 @@ defmodule Lightning.WorkflowVersionsTest do
 
   alias Lightning.Repo
   alias Lightning.WorkflowVersions
-  alias Lightning.Workflows.{Workflow, WorkflowVersion}
+  alias Lightning.Workflows.{WorkflowVersion}
 
   @a "aaaaaaaaaaaa"
   @b "bbbbbbbbbbbb"

test/lightning_web/live/ai_assistant_live_test.exs

@@ -310,10 +310,10 @@ defmodule LightningWeb.AiAssistantLiveTest do
           )
 
         assert has_element?(input_element)
-        refute render(input_element) =~ "disabled=\"disabled\""
+        refute render(input_element) =~ "disabled=\"\""
         assert has_element?(submit_btn)
         # Submit button should be disabled when no content is entered
-        assert render(submit_btn) =~ "disabled=\"disabled\""
+        assert render(submit_btn) =~ "disabled=\"\""
 
         html =
           view
@@ -367,9 +367,9 @@ defmodule LightningWeb.AiAssistantLiveTest do
           )
 
         assert has_element?(input_element)
-        assert render(input_element) =~ "disabled=\"disabled\""
+        assert render(input_element) =~ "disabled=\"\""
         assert has_element?(submit_btn)
-        assert render(submit_btn) =~ "disabled=\"disabled\""
+        assert render(submit_btn) =~ "disabled=\"\""
 
         html =
           view
@@ -431,9 +431,9 @@ defmodule LightningWeb.AiAssistantLiveTest do
         )
 
       assert has_element?(input_element)
-      assert render(input_element) =~ "disabled=\"disabled\""
+      assert render(input_element) =~ "disabled=\"\""
       assert has_element?(submit_btn)
-      assert render(submit_btn) =~ "disabled=\"disabled\""
+      assert render(submit_btn) =~ "disabled=\"\""
 
       assert render(input_element) =~
                ~s(placeholder="Save your workflow first to use the AI Assistant")
@@ -2077,7 +2077,7 @@ defmodule LightningWeb.AiAssistantLiveTest do
       create_btn_after = element(view, "#create_workflow_btn")
       create_btn_html_after = render(create_btn_after)
 
-      refute create_btn_html_after =~ "disabled=\"disabled\"",
+      refute create_btn_html_after =~ "disabled=\"\"",
              "Create button should be enabled after template selection"
     end
 
@@ -2353,9 +2353,9 @@ defmodule LightningWeb.AiAssistantLiveTest do
           "#ai-assistant-form-submit-btn-chat-input-new-workflow-panel-assistant"
         )
 
-      refute render(input_element) =~ "disabled=\"disabled\""
+      refute render(input_element) =~ "disabled=\"\""
       # Submit button should be disabled when no content is entered
-      assert render(submit_btn) =~ "disabled=\"disabled\""
+      assert render(submit_btn) =~ "disabled=\"\""
 
       refute render(input_element) =~ "Save your workflow first"
     end

test/lightning_web/live/credential_live_test.exs

@@ -2865,7 +2865,7 @@ defmodule LightningWeb.CredentialLiveTest do
 
       refute view
              |> has_element?(
-               "span[phx-hook='Tooltip', aria-label='OAuth client not found']"
+               "span[phx-hook='Tooltip'][aria-label='OAuth client not found']"
              )
 
       # Now lets delete the oauth client

test/lightning_web/live/project_live_test.exs

@@ -1835,14 +1835,10 @@ defmodule LightningWeb.ProjectLiveTest do
       assert html =~ "Project settings"
 
       assert view
-             |> has_element?(
-               "input[disabled='disabled'][name='project[raw_name]']"
-             )
+             |> has_element?("input[disabled][name='project[raw_name]']")
 
       assert view
-             |> has_element?(
-               "textarea[disabled='disabled'][name='project[description]']"
-             )
+             |> has_element?("textarea[disabled][name='project[description]']")
 
       assert view |> has_element?("button[disabled][type=submit]")
 
@@ -1869,14 +1865,10 @@ defmodule LightningWeb.ProjectLiveTest do
       assert html =~ "Project settings"
 
       assert view
-             |> has_element?(
-               "input[disabled='disabled'][name='project[raw_name]']"
-             )
+             |> has_element?("input[disabled][name='project[raw_name]']")
 
       assert view
-             |> has_element?(
-               "textarea[disabled='disabled'][name='project[description]']"
-             )
+             |> has_element?("textarea[disabled][name='project[description]']")
 
       assert view |> has_element?("button[disabled][type=submit]")
 
@@ -2755,7 +2747,7 @@ defmodule LightningWeb.ProjectLiveTest do
       assert html =~ "Should OpenFn store input/output data for workflow runs?"
 
       # retain_all is the default
-      assert ["checked"] ==
+      assert [""] ==
                view
                |> element("#retain_all")
                |> render()
@@ -2770,7 +2762,7 @@ defmodule LightningWeb.ProjectLiveTest do
       #          |> Floki.parse_fragment!()
       #          |> Floki.attribute("input", "checked")
 
-      refute ["checked"] ==
+      assert [] ==
                view
                |> element("#erase_all")
                |> render()
@@ -2783,7 +2775,7 @@ defmodule LightningWeb.ProjectLiveTest do
       # 3 radio buttons descriptions
       assert "Retain input/output data for all workflow runs" =
                view
-               |> element(~s{label#[for="retain_all"]})
+               |> element(~s{label[for="retain_all"]})
                |> render()
                |> Floki.parse_fragment!()
                |> Floki.text()
@@ -2800,7 +2792,7 @@ defmodule LightningWeb.ProjectLiveTest do
 
       assert "Never retain input/output data (zero-persistence)" =
                view
-               |> element(~s{label#[for="erase_all"]})
+               |> element(~s{label[for="erase_all"]})
                |> render()
                |> Floki.parse_fragment!()
                |> Floki.text()
@@ -2841,7 +2833,7 @@ defmodule LightningWeb.ProjectLiveTest do
       )
       |> render_change()
 
-      assert ["checked"] ==
+      assert [""] ==
                view
                |> element("#erase_all")
                |> render()
@@ -2873,7 +2865,7 @@ defmodule LightningWeb.ProjectLiveTest do
       )
       |> render_change()
 
-      assert ["checked"] ==
+      assert [""] ==
                view
                |> element("#erase_all")
                |> render()
@@ -2886,7 +2878,7 @@ defmodule LightningWeb.ProjectLiveTest do
       |> render_click()
 
       # Verify it resets back to retain_all (the default)
-      assert ["checked"] ==
+      assert [""] ==
                view
                |> element("#retain_all")
                |> render()
@@ -2972,7 +2964,7 @@ defmodule LightningWeb.ProjectLiveTest do
           )
           |> render_change()
 
-          assert ["checked"] ==
+          assert [""] ==
                    view
                    |> element("#" <> policy)
                    |> render()
@@ -2998,7 +2990,7 @@ defmodule LightningWeb.ProjectLiveTest do
           {:ok, view, _html} =
             live(conn, ~p"/projects/#{project.id}/settings#data-storage")
 
-          assert ["checked"] ==
+          assert [""] ==
                    view
                    |> element("#" <> policy)
                    |> render()
@@ -5217,7 +5209,7 @@ defmodule LightningWeb.ProjectLiveTest do
           "Connect Branch & Initiate First Sync"
         )
 
-      assert render(submit_btn) =~ "disabled=\"disabled\""
+      assert render(submit_btn) =~ "disabled=\"\""
     end
 
     @tag :capture_log
@@ -6229,7 +6221,7 @@ defmodule LightningWeb.ProjectLiveTest do
         button = element(view, "#initiate-sync-button")
         assert has_element?(button)
 
-        assert render(button) =~ "disabled=\"disabled\""
+        assert render(button) =~ "disabled=\"\""
       end
     end
 

test/lightning_web/live/sandbox_live/form_component_test.exs

@@ -121,7 +121,7 @@ defmodule LightningWeb.SandboxLive.FormComponentTest do
       )
 
       html = render(view)
-      assert html =~ ~s(<button disabled="disabled" type="submit")
+      assert html =~ ~s(<button disabled="" type="submit")
       assert html =~ "can&#39;t be blank"
 
       # Verify the validation error only appears once (fixes #4490)

test/lightning_web/live/work_order_live_test.exs

@@ -998,7 +998,7 @@ defmodule LightningWeb.WorkOrderLiveTest do
 
       div =
         view
-        |> element("tbody:first-child")
+        |> element("#work-orders-table")
         |> render_async()
 
       refute div =~ "workflow 1"
@@ -1008,7 +1008,7 @@ defmodule LightningWeb.WorkOrderLiveTest do
 
       div =
         view
-        |> element("tbody:first-child")
+        |> element("#work-orders-table")
         |> render_async()
 
       assert div =~ "workflow 1"
@@ -1110,7 +1110,9 @@ defmodule LightningWeb.WorkOrderLiveTest do
 
       div =
         view
-        |> element("tbody:first-child td.text-right:nth-child(8)")
+        |> element(
+          "tbody#workorder-#{work_order_two.id} td.text-right:nth-child(8)"
+        )
         |> render()
 
       assert div =~ "Failed"
@@ -1807,7 +1809,7 @@ defmodule LightningWeb.WorkOrderLiveTest do
   def workflow_displayed(view, name) do
     elem =
       view
-      |> element("tbody:first-child")
+      |> element("#work-orders-table")
 
     if elem |> has_element?() do
       elem |> render() =~ name

test/lightning_web/live/workflow_live/edit_test.exs

@@ -522,7 +522,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
 
       refute view
              |> element("#create_workflow_btn")
-             |> render() =~ "disabled=\"disabled\""
+             |> render() =~ "disabled=\"\""
 
       # Test with invalid payload (missing required fields)
       invalid_payload = %{
@@ -542,7 +542,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
 
       assert view
              |> element("#create_workflow_btn")
-             |> render() =~ "disabled=\"disabled\""
+             |> render() =~ "disabled=\"\""
     end
 
     @tag role: :editor
@@ -725,7 +725,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
 
       refute view
              |> has_element?(
-               "[id='version-switcher-canvas-#{workflow.id}][data-version='latest']"
+               "[id='version-switcher-canvas-#{workflow.id}'][data-version='latest']"
              )
 
       view |> fill_workflow_name("#{workflow.name} v2")
@@ -763,7 +763,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
                )
 
         refute view
-               |> has_element?("[id='version-switcher-inspector-#{job.id}]")
+               |> has_element?("[id='version-switcher-inspector-#{job.id}']")
 
         refute view
                |> has_element?(
@@ -890,7 +890,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
         #        )
 
         assert view
-               |> has_element?("[id='version-switcher-toggle-#{job.id}]")
+               |> has_element?("[id='version-switcher-toggle-#{job.id}']")
 
         assert view |> save_is_disabled?()
       end)
@@ -1664,13 +1664,13 @@ defmodule LightningWeb.WorkflowLive.EditTest do
       assert form_html =~ "Label"
 
       assert form_html =~
-               ~S[<option selected="selected" value="always">Always</option><option value="js_expression">Matches a Javascript Expression</option></select>]
+               ~S[<option selected="" value="always">Always</option><option value="js_expression">Matches a Javascript Expression</option></select>]
 
       edge_on_edit = Enum.at(workflow.edges, 1)
       form_html = view |> select_node(edge_on_edit, workflow.lock_version)
 
       assert form_html =~
-               ~S[<option selected="selected" value="on_job_success">On Success</option>]
+               ~S[<option selected="" value="on_job_success">On Success</option>]
 
       form_html =
         view
@@ -1684,7 +1684,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
       assert form_html =~ "Label"
 
       assert form_html =~
-               ~S[<option selected="selected" value="js_expression">Matches a Javascript Expression</option>]
+               ~S[<option selected="" value="js_expression">Matches a Javascript Expression</option>]
 
       view
       |> form("#workflow-form", %{
@@ -2947,7 +2947,7 @@ defmodule LightningWeb.WorkflowLive.EditTest do
 
       assert view
              |> element("button#submit-btn-github-sync-modal")
-             |> render() =~ "disabled=\"disabled\""
+             |> render() =~ "disabled=\"\""
     end
   end
 

test/lightning_web/live/workflow_live/editor_test.exs

@@ -1317,11 +1317,11 @@ defmodule LightningWeb.WorkflowLive.EditorTest do
       live_children(view) |> Enum.each(&render_async/1)
 
       # user gets no option to rerun
-      assert has_element?(view, "button[disabled='disabled']", "Run (Retry)")
+      assert has_element?(view, "button[disabled]", "Run (Retry)")
 
       assert has_element?(
                view,
-               "button[disabled='disabled']",
+               "button[disabled]",
                "Run"
              )