Skip to content

Commit 563e4a8

Browse files
dermatzdermatz
committed
♻️ refactor: suppress warnings for code complexity and security
1 parent 0dfbb6a commit 563e4a8

7 files changed

Lines changed: 36 additions & 0 deletions

File tree

‎src/Console/Command/System/CheckCommand.php‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515

1616
/**
1717
* Command for checking system information
18+
*
19+
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
20+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1821
*/
1922
class CheckCommand extends AbstractCommand
2023
{
@@ -112,6 +115,7 @@ protected function executeCommand(InputInterface $input, OutputInterface $output
112115
*/
113116
private function getNodeVersion(): string
114117
{
118+
// phpcs:ignore Security.BadFunctions.SystemExecFunctions -- exec with static command is safe
115119
exec('node -v 2>/dev/null', $output, $returnCode);
116120
return $returnCode === 0 && !empty($output) ? trim($output[0], 'v') : 'Not installed';
117121
}
@@ -124,6 +128,7 @@ private function getNodeVersion(): string
124128
private function getLatestLtsNodeVersion(): string
125129
{
126130
try {
131+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- file_get_contents with static HTTPS URL is safe
127132
$nodeData = file_get_contents(self::NODE_LTS_URL);
128133
if ($nodeData === false) {
129134
return 'Unknown';
@@ -197,6 +202,7 @@ private function getMysqlVersionViaMagento(): ?string
197202
*/
198203
private function getMysqlVersionViaClient(): ?string
199204
{
205+
// phpcs:ignore Security.BadFunctions.SystemExecFunctions -- exec with static command is safe
200206
exec('mysql --version 2>/dev/null', $output, $returnCode);
201207
if ($returnCode === 0 && !empty($output)) {
202208
$versionString = $output[0];
@@ -290,6 +296,7 @@ private function getShortOsInfo(): string
290296
*/
291297
private function getComposerVersion(): string
292298
{
299+
// phpcs:ignore Security.BadFunctions.SystemExecFunctions -- exec with static command is safe
293300
exec('composer --version 2>/dev/null', $output, $returnCode);
294301
if ($returnCode !== 0 || empty($output)) {
295302
return 'Not installed';
@@ -306,6 +313,7 @@ private function getComposerVersion(): string
306313
*/
307314
private function getNpmVersion(): string
308315
{
316+
// phpcs:ignore Security.BadFunctions.SystemExecFunctions -- exec with static command is safe
309317
exec('npm --version 2>/dev/null', $output, $returnCode);
310318
return $returnCode === 0 && !empty($output) ? trim($output[0]) : 'Not installed';
311319
}
@@ -317,6 +325,7 @@ private function getNpmVersion(): string
317325
*/
318326
private function getGitVersion(): string
319327
{
328+
// phpcs:ignore Security.BadFunctions.SystemExecFunctions -- exec with static command is safe
320329
exec('git --version 2>/dev/null', $output, $returnCode);
321330
if ($returnCode !== 0 || empty($output)) {
322331
return 'Not installed';

‎src/Console/Command/Theme/BuildCommand.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919

2020
/**
2121
* Command for building Magento themes
22+
*
23+
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
24+
* @SuppressWarnings(PHPMD.TooManyMethods)
2225
*/
2326
class BuildCommand extends AbstractCommand
2427
{
@@ -63,6 +66,7 @@ protected function executeCommand(InputInterface $input, OutputInterface $output
6366

6467
if (empty($themeCodes)) {
6568
$themes = $this->themeList->getAllThemes();
69+
// phpcs:ignore Security.BadFunctions.CallbackFunctions -- array_map with safe callback is acceptable
6670
$options = array_map(fn($theme) => $theme->getCode(), $themes);
6771

6872
// Check if we're in an interactive terminal environment

‎src/Service/StaticContentDeployer.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public function deploy(
3636
$io->text('Deploying static content...');
3737
}
3838

39+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- escapeshellarg is the correct function for sanitizing shell arguments
3940
$sanitizedThemeCode = escapeshellarg($themeCode);
4041
$shellOutput = $this->shell->execute(
4142
"php bin/magento setup:static-content:deploy -t %s -f --quiet",

‎src/Service/ThemeBuilder/BuilderFactory.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public function addBuilder(BuilderInterface $builder): void
1616
public function create(string $type): BuilderInterface
1717
{
1818
if (!isset($this->builders[$type])) {
19+
// phpcs:ignore WordPress.Security.EscapeOutput -- Exception message is properly escaped with htmlspecialchars
1920
throw new \InvalidArgumentException("Builder " . htmlspecialchars($type, ENT_QUOTES, 'UTF-8') . " not found");
2021
}
2122

‎src/Service/ThemeBuilder/HyvaThemes/Builder.php‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public function build(string $themePath, SymfonyStyle $io, OutputInterface $outp
7373
}
7474

7575
// Deploy static content
76+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- basename is safe here for extracting theme name from validated path
7677
$themeCode = basename($themePath);
7778
if (!$this->staticContentDeployer->deploy($themeCode, $io, $output, $isVerbose)) {
7879
return false;
@@ -115,6 +116,7 @@ private function buildTheme(string $themePath, SymfonyStyle $io, bool $isVerbose
115116

116117
// Change to tailwind directory and run build
117118
$currentDir = getcwd();
119+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
118120
chdir($tailwindPath);
119121

120122
try {
@@ -125,10 +127,12 @@ private function buildTheme(string $themePath, SymfonyStyle $io, bool $isVerbose
125127
if ($isVerbose) {
126128
$io->success('Hyvä theme build completed successfully.');
127129
}
130+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
128131
chdir($currentDir);
129132
return true;
130133
} catch (\Exception $e) {
131134
$io->error('Failed to build Hyvä theme: ' . $e->getMessage());
135+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
132136
chdir($currentDir);
133137
return false;
134138
}
@@ -163,6 +167,7 @@ private function installNodeModules(string $tailwindPath, SymfonyStyle $io, bool
163167
}
164168

165169
$currentDir = getcwd();
170+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
166171
chdir($tailwindPath);
167172

168173
try {
@@ -179,10 +184,12 @@ private function installNodeModules(string $tailwindPath, SymfonyStyle $io, bool
179184
$io->success('Node modules installed successfully.');
180185
}
181186

187+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
182188
chdir($currentDir);
183189
return true;
184190
} catch (\Exception $e) {
185191
$io->error('Failed to install node modules: ' . $e->getMessage());
192+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
186193
chdir($currentDir);
187194
return false;
188195
}
@@ -194,6 +201,7 @@ private function installNodeModules(string $tailwindPath, SymfonyStyle $io, bool
194201
private function checkOutdatedPackages(string $tailwindPath, SymfonyStyle $io): void
195202
{
196203
$currentDir = getcwd();
204+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
197205
chdir($tailwindPath);
198206

199207
try {
@@ -206,6 +214,7 @@ private function checkOutdatedPackages(string $tailwindPath, SymfonyStyle $io):
206214
// Ignore errors from npm outdated as it returns non-zero when packages are outdated
207215
}
208216

217+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
209218
chdir($currentDir);
210219
}
211220

@@ -226,6 +235,7 @@ public function watch(string $themePath, SymfonyStyle $io, OutputInterface $outp
226235
}
227236

228237
try {
238+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
229239
chdir($tailwindPath);
230240
passthru('npm run watch');
231241
} catch (\Exception $e) {

‎src/Service/ThemeBuilder/MagentoStandard/Builder.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ public function build(string $themePath, SymfonyStyle $io, OutputInterface $outp
6666
}
6767

6868
// Deploy static content
69+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- basename is safe here for extracting theme name from validated path
6970
$themeCode = basename($themePath);
7071
if (!$this->staticContentDeployer->deploy($themeCode, $io, $output, $isVerbose)) {
7172
return false;

‎src/Service/ThemeBuilder/TailwindCSS/Builder.php‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public function build(string $themePath, SymfonyStyle $io, OutputInterface $outp
7373

7474
// Change to tailwind directory and run build
7575
$currentDir = getcwd();
76+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
7677
chdir($tailwindPath);
7778

7879
try {
@@ -85,13 +86,16 @@ public function build(string $themePath, SymfonyStyle $io, OutputInterface $outp
8586
}
8687
} catch (\Exception $e) {
8788
$io->error('Failed to build custom TailwindCSS theme: ' . $e->getMessage());
89+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
8890
chdir($currentDir);
8991
return false;
9092
}
9193

94+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
9295
chdir($currentDir);
9396

9497
// Deploy static content
98+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- basename is safe here for extracting theme name from validated path
9599
$themeCode = basename($themePath);
96100
if (!$this->staticContentDeployer->deploy($themeCode, $io, $output, $isVerbose)) {
97101
return false;
@@ -134,6 +138,7 @@ private function installNodeModules(string $tailwindPath, SymfonyStyle $io, bool
134138
}
135139

136140
$currentDir = getcwd();
141+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
137142
chdir($tailwindPath);
138143

139144
try {
@@ -148,10 +153,12 @@ private function installNodeModules(string $tailwindPath, SymfonyStyle $io, bool
148153
if ($isVerbose) {
149154
$io->success('Node modules installed successfully.');
150155
}
156+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
151157
chdir($currentDir);
152158
return true;
153159
} catch (\Exception $e) {
154160
$io->error('Failed to install node modules: ' . $e->getMessage());
161+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
155162
chdir($currentDir);
156163
return false;
157164
}
@@ -163,6 +170,7 @@ private function installNodeModules(string $tailwindPath, SymfonyStyle $io, bool
163170
private function checkOutdatedPackages(string $tailwindPath, SymfonyStyle $io): void
164171
{
165172
$currentDir = getcwd();
173+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
166174
chdir($tailwindPath);
167175
try {
168176
$outdated = $this->shell->execute('npm outdated --json');
@@ -173,6 +181,7 @@ private function checkOutdatedPackages(string $tailwindPath, SymfonyStyle $io):
173181
} catch (\Exception $e) {
174182
// Ignore errors from npm outdated as it returns non-zero when packages are outdated
175183
}
184+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary to restore original directory
176185
chdir($currentDir);
177186
}
178187

@@ -198,6 +207,7 @@ public function watch(string $themePath, SymfonyStyle $io, OutputInterface $outp
198207
}
199208

200209
try {
210+
// phpcs:ignore MEQP1.Security.DiscouragedFunction -- chdir is necessary for npm to run in correct context
201211
chdir($tailwindPath);
202212
passthru('npm run watch');
203213
} catch (\Exception $e) {

0 commit comments

Comments
 (0)