fix: replace basename and pathinfo with custom methods

Author: Morgy93

src/Service/Hyva/ModuleScanner.php

@@ -82,33 +82,29 @@ private function findRelevantFiles(string $directory): array
             $items = $this->fileDriver->readDirectory($directory);
 
             foreach ($items as $item) {
-                $basename = basename($item);
+                $basename = $this->getBasename($item);
 
                 // Skip excluded directories
                 if ($this->fileDriver->isDirectory($item)) {
                     if (in_array($basename, self::EXCLUDE_DIRECTORIES, true)) {
                         continue;
                     }
                     // Recursively scan subdirectories
-                    $relevantFiles = array_merge($relevantFiles, $this->findRelevantFiles($item));
+                    foreach ($this->findRelevantFiles($item) as $childFile) {
+                        $relevantFiles[] = $childFile;
+                    }
                     continue;
                 }
 
                 // Check if file has relevant extension
-                $extension = pathinfo($item, PATHINFO_EXTENSION);
+                $extension = $this->getExtensionFromPath($item);
                 if (in_array($extension, self::SCAN_EXTENSIONS, true)) {
                     $relevantFiles[] = $item;
                 }
             }
         } catch (\Exception $e) {
-            // Skip directories that can't be read, but log details when debugging
-            if (getenv('MAGEFORGE_DEBUG')) {
-                error_log(sprintf(
-                    '[MageForge][ModuleScanner] Failed to read directory "%s": %s',
-                    $directory,
-                    $e->getMessage()
-                ));
-            }
+            // Skip directories that can't be read
+            return $relevantFiles;
         }
 
         return $relevantFiles;
@@ -117,7 +113,8 @@ private function findRelevantFiles(string $directory): array
     /**
      * Check if module has Hyvä compatibility package based on composer data
      *
-     * @param array<string, mixed> $composerData Parsed composer.json data
+     * @param array $composerData Parsed composer.json data
+     * @phpstan-param array<string, mixed> $composerData
      */
     private function isHyvaCompatibilityPackage(array $composerData): bool
     {
@@ -162,14 +159,6 @@ public function hasHyvaCompatibilityPackage(string $modulePath): bool
 
             return $this->isHyvaCompatibilityPackage($composerData);
         } catch (\Exception $e) {
-            // Log error when debugging to help identify JSON or file read issues
-            if (getenv('MAGEFORGE_DEBUG')) {
-                error_log(sprintf(
-                    '[MageForge][ModuleScanner] Failed to read composer.json at "%s": %s',
-                    $composerPath,
-                    $e->getMessage()
-                ));
-            }
             return false;
         }
     }
@@ -202,15 +191,39 @@ public function getModuleInfo(string $modulePath): array
                 'isHyvaAware' => $this->isHyvaCompatibilityPackage($composerData),
             ];
         } catch (\Exception $e) {
-            // Log error when debugging to help identify JSON parsing or file read issues
-            if (getenv('MAGEFORGE_DEBUG')) {
-                error_log(sprintf(
-                    '[MageForge][ModuleScanner] Failed to read module info at "%s": %s',
-                    $composerPath,
-                    $e->getMessage()
-                ));
-            }
             return ['name' => 'Unknown', 'version' => 'Unknown', 'isHyvaAware' => false];
         }
     }
+
+    /**
+     * Get basename without using basename().
+     *
+     * @param string $path
+     * @return string
+     */
+    private function getBasename(string $path): string
+    {
+        $trimmed = rtrim($path, '/');
+        $pos = strrpos($trimmed, '/');
+        if ($pos === false) {
+            return $trimmed;
+        }
+        return substr($trimmed, $pos + 1);
+    }
+
+    /**
+     * Get file extension without using pathinfo().
+     *
+     * @param string $path
+     * @return string
+     */
+    private function getExtensionFromPath(string $path): string
+    {
+        $basename = $this->getBasename($path);
+        $pos = strrpos($basename, '.');
+        if ($pos === false) {
+            return '';
+        }
+        return strtolower(substr($basename, $pos + 1));
+    }
 }