fix: remove unused constants and simplify returns

Author: Morgy93

src/Console/Command/Dev/InspectorCommand.php

@@ -116,7 +116,6 @@ protected function executeCommand(InputInterface $input, OutputInterface $output
             'enable' => $this->enableInspector(),
             'disable' => $this->disableInspector(),
             'status' => $this->showStatus(),
-            default => Cli::RETURN_FAILURE,
         };
     }
 

src/Console/Command/System/VersionCommand.php

@@ -17,7 +17,6 @@
 class VersionCommand extends AbstractCommand
 {
     private const API_URL = 'https://api.github.com/repos/openforgeproject/mageforge/releases/latest';
-    private const PACKAGE_NAME = 'openforgeproject/mageforge';
     private const UNKNOWN_VERSION = 'Unknown';
 
     /**

src/Console/Command/Theme/TokensCommand.php

@@ -125,7 +125,7 @@ private function validateHyvaTheme(string $themeCode, OutputInterface $output):
 
             // If no theme was selected, exit
             if ($correctedTheme === null) {
-                return Cli::RETURN_FAILURE;
+                return null;
             }
 
             // Use the corrected theme code
@@ -135,7 +135,7 @@ private function validateHyvaTheme(string $themeCode, OutputInterface $output):
             // Double-check the corrected theme exists
             if ($themePath === null) {
                 $this->io->error("Theme $themeCode is not installed.");
-                return Cli::RETURN_FAILURE;
+                return null;
             }
 
             $this->io->info("Using theme: $themeCode");

src/Model/TemplateEngine/Decorator/InspectorHints.php

@@ -62,6 +62,10 @@ public function render(BlockInterface $block, $templateFile, array $dictionary =
     {
         $result = $this->subject->render($block, $templateFile, $dictionary);
 
+        if (!$this->showBlockHints) {
+            return $result;
+        }
+
         // Only inject attributes if there's actual HTML content
         if (empty(trim($result))) {
             return $result;

src/Model/ThemePath.php

@@ -6,14 +6,11 @@
 
 use Magento\Framework\Component\ComponentRegistrar;
 use Magento\Framework\Component\ComponentRegistrarInterface;
-use Magento\Theme\Model\ResourceModel\Theme\Collection as ThemeCollection;
 
 class ThemePath
 {
     public function __construct(
-        private readonly ThemeList $themeList,
-        private readonly ComponentRegistrarInterface $componentRegistrar,
-        private readonly ThemeCollection $themeCollection
+        private readonly ComponentRegistrarInterface $componentRegistrar
     ) {
     }
 

src/Service/Hyva/CompatibilityChecker.php

@@ -19,8 +19,7 @@ class CompatibilityChecker
 {
     public function __construct(
         private readonly ComponentRegistrarInterface $componentRegistrar,
-        private readonly ModuleScanner $moduleScanner,
-        private readonly IncompatibilityDetector $incompatibilityDetector
+        private readonly ModuleScanner $moduleScanner
     ) {
     }
 

src/Service/StaticContentCleaner.php

@@ -61,7 +61,7 @@ public function cleanIfNeeded(
             $cleanedStatic = $this->themeCleaner->cleanPubStatic($themeCode, $io, false, $isVerbose);
             $cleanedPreprocessed = $this->themeCleaner->cleanViewPreprocessed($themeCode, $io, false, $isVerbose);
 
-            return ($cleanedStatic > 0 || $cleanedPreprocessed > 0) || !$this->themeCleaner->hasStaticFiles($themeCode);
+            return ($cleanedStatic > 0 || $cleanedPreprocessed > 0);
         } catch (\Exception $e) {
             $io->error('Failed to check/clean static content: ' . $e->getMessage());
             return false;