feat: improve theme selection handling in CopyFromVendorCommand

Author: dermatz

src/Console/Command/Theme/CopyFromVendorCommand.php

@@ -141,16 +141,29 @@ private function getThemeCode(InputInterface $input): string
             throw new \RuntimeException('No themes found to copy to.');
         }
 
+        if (!$input->isInteractive()) {
+            $themeList = implode(', ', array_keys($options));
+            throw new \RuntimeException(
+                "Theme argument is missing. Available themes: $themeList"
+            );
+        }
+
         $this->fixPromptEnvironment();
 
-        return (string) search(
-            label: 'Select target theme',
-            options: fn (string $value) => array_filter(
-                $options,
-                fn ($option) => str_contains(strtolower($option), strtolower($value))
-            ),
-            placeholder: 'Search for a theme...'
-        );
+        try {
+            $result = search(
+                label: 'Select target theme',
+                options: fn (string $value) => array_filter(
+                    $options,
+                    fn ($option) => str_contains(strtolower($option), strtolower($value))
+                ),
+                placeholder: 'Search for a theme...'
+            );
+            \Laravel\Prompts\Prompt::terminal()->restoreTty();
+            return (string) $result;
+        } finally {
+            $this->resetPromptEnvironment();
+        }
     }
 
     /**

src/Service/VendorFileMapper.php

@@ -211,29 +211,32 @@ private function isAreaCompatible(string $sourceArea, string $targetArea): bool
      *
      * @param string $compatModuleName
      * @return string|null
+     * @phpcs:disable Magento2.PHP.LiteralNamespaces.LiteralClassUsage
      */
     private function getOriginalModuleFromCompatRegistry(string $compatModuleName): ?string
     {
+        $registryClass = 'Hyva\CompatModuleFallback\Model\CompatModuleRegistry';
+        //phpcs:enable
+
         // 1. Try Registry (via Emulated Area)
-        if (!class_exists(\Hyva\CompatModuleFallback\Model\CompatModuleRegistry::class)) {
+        if (!class_exists($registryClass)) {
             return $this->parseCompatModuleXml($compatModuleName);
         }
 
         try {
             // Emulate frontend area to load proper DI configuration for CompatModuleRegistry
             // as CLI commands run in global scope where frontend/di.xml is ignored.
-            /** @var \Hyva\CompatModuleFallback\Model\CompatModuleRegistry|null $registry */
+            /** @var mixed|\Hyva\CompatModuleFallback\Model\CompatModuleRegistry|null $registry */
             $registry = $this->appState->emulateAreaCode(
                 Area::AREA_FRONTEND,
-                function () {
+                function () use ($registryClass) {
                     // Use create() to ensure we get a fresh instance with the emulated configuration.
                     // get() might return a cached instance from global scope (empty).
-                    return $this->objectManager->create(\Hyva\CompatModuleFallback\Model\CompatModuleRegistry::class);
+                    return $this->objectManager->create($registryClass);
                 }
             );
 
             if ($registry) {
-                 /** @var \Hyva\CompatModuleFallback\Model\CompatModuleRegistry $registry */
                 return $this->findOriginalModuleInRegistry($registry, $compatModuleName);
             }
         } catch (\Throwable $e) {
@@ -248,7 +251,7 @@ function () {
     /**
      * Find original module in registry
      *
-     * @param \Hyva\CompatModuleFallback\Model\CompatModuleRegistry $registry
+     * @param mixed $registry Hyva\CompatModuleFallback\Model\CompatModuleRegistry
      * @param string $compatModuleName
      * @return string|null
      */
@@ -366,6 +369,8 @@ private function parseDiFileForCompatModule(string $diPath, string $moduleName):
     }
 
     /**
+     * Find original module in XML items
+     *
      * @param \DOMNodeList<\DOMNode> $items
      * @param \DOMXPath $xpath
      * @param string $moduleName