fix: refactor constructors for property promotion

Author: Morgy93

src/Block/Inspector.php

@@ -19,29 +19,13 @@ class Inspector extends Template
 {
     private const XML_PATH_INSPECTOR_ENABLED = 'dev/mageforge_inspector/enabled';
 
-    private State $state;
-
-    private ScopeConfigInterface $scopeConfig;
-
-    private DevHelper $devHelper;
-
-    /**
-     * @param Context $context
-     * @param State $state
-     * @param ScopeConfigInterface $scopeConfig
-     * @param DevHelper $devHelper
-     * @param array $data
-     */
     public function __construct(
         Context $context,
-        State $state,
-        ScopeConfigInterface $scopeConfig,
-        DevHelper $devHelper,
+        private readonly State $state,
+        private readonly ScopeConfigInterface $scopeConfig,
+        private readonly DevHelper $devHelper,
         array $data = []
     ) {
-        $this->state = $state;
-        $this->scopeConfig = $scopeConfig;
-        $this->devHelper = $devHelper;
         parent::__construct($context, $data);
     }
 

src/Console/Command/Dev/InspectorCommand.php

@@ -21,27 +21,12 @@ class InspectorCommand extends AbstractCommand
     private const XML_PATH_INSPECTOR_ENABLED = 'dev/mageforge_inspector/enabled';
     private const ARGUMENT_ACTION = 'action';
 
-    private WriterInterface $configWriter;
-
-    private State $state;
-
-    private CacheManager $cacheManager;
-
-    /**
-     * @param WriterInterface $configWriter
-     * @param State $state
-     * @param CacheManager $cacheManager
-     * @param string|null $name
-     */
     public function __construct(
-        WriterInterface $configWriter,
-        State $state,
-        CacheManager $cacheManager,
+        private readonly WriterInterface $configWriter,
+        private readonly State $state,
+        private readonly CacheManager $cacheManager,
         ?string $name = null
     ) {
-        $this->configWriter = $configWriter;
-        $this->state = $state;
-        $this->cacheManager = $cacheManager;
         parent::__construct($name);
     }
 

src/Model/TemplateEngine/Decorator/InspectorHints.php

@@ -16,12 +16,6 @@
  */
 class InspectorHints implements TemplateEngineInterface
 {
-    private TemplateEngineInterface $subject;
-
-    private bool $showBlockHints;
-
-    private Random $random;
-
     private string $magentoRoot;
 
     /**
@@ -30,14 +24,10 @@ class InspectorHints implements TemplateEngineInterface
      * @param Random $random
      */
     public function __construct(
-        TemplateEngineInterface $subject,
-        bool $showBlockHints,
-        Random $random
+        private readonly TemplateEngineInterface $subject,
+        private readonly bool $showBlockHints,
+        private readonly Random $random
     ) {
-        $this->subject = $subject;
-        $this->showBlockHints = $showBlockHints;
-        $this->random = $random;
-
         // Get Magento root directory - try multiple strategies
         // 1. Try from BP constant (most reliable)
         if (defined('BP')) {

src/Model/TemplateEngine/Plugin/InspectorHints.php

@@ -22,35 +22,13 @@ class InspectorHints
 {
     private const XML_PATH_INSPECTOR_ENABLED = 'dev/mageforge_inspector/enabled';
 
-    private ScopeConfigInterface $scopeConfig;
-
-    private StoreManagerInterface $storeManager;
-
-    private DevHelper $devHelper;
-
-    private InspectorHintsFactory $inspectorHintsFactory;
-
-    private State $state;
-
-    /**
-     * @param ScopeConfigInterface $scopeConfig
-     * @param StoreManagerInterface $storeManager
-     * @param DevHelper $devHelper
-     * @param InspectorHintsFactory $inspectorHintsFactory
-     * @param State $state
-     */
     public function __construct(
-        ScopeConfigInterface $scopeConfig,
-        StoreManagerInterface $storeManager,
-        DevHelper $devHelper,
-        InspectorHintsFactory $inspectorHintsFactory,
-        State $state
+        private readonly ScopeConfigInterface $scopeConfig,
+        private readonly StoreManagerInterface $storeManager,
+        private readonly DevHelper $devHelper,
+        private readonly InspectorHintsFactory $inspectorHintsFactory,
+        private readonly State $state
     ) {
-        $this->scopeConfig = $scopeConfig;
-        $this->storeManager = $storeManager;
-        $this->devHelper = $devHelper;
-        $this->inspectorHintsFactory = $inspectorHintsFactory;
-        $this->state = $state;
     }
 
     /**

src/Service/ThemeBuilder/BuilderPool.php

@@ -6,16 +6,12 @@
 
 class BuilderPool
 {
-    /** @var BuilderInterface[] */
-    private array $builders;
-
     /**
      * @param BuilderInterface[] $builders
      */
     public function __construct(
-        array $builders = []
+        private readonly array $builders = []
     ) {
-        $this->builders = $builders;
     }
 
     public function getBuilder(string $themePath): ?BuilderInterface