Allow guest editing anywhere (server & local)

Author: OpenHypervideo

src/_shared/frametrail-core/storage/StorageAdapterDownload.js

@@ -16,39 +16,23 @@ class StorageAdapterDownload extends StorageAdapter {
     constructor() {
         super();
         this._data = {};  // In-memory cache
-
-        // Pre-load user identity so isLoggedIn() works before init() is called.
-        // If a returning user is stored in localStorage, use it immediately.
-        // Otherwise set a default so the edit button is visible; init() will
-        // prompt for a real name on the first save attempt.
-        var storedUser = null;
-        try { storedUser = JSON.parse(localStorage.getItem('frametrail_local_user')); } catch (e) {}
-        this._userInfo = (storedUser && storedUser.id)
-            ? storedUser
-            : { id: 'localuser', name: 'Local User', role: 'admin', mail: '', color: '#FF9800' };
+        this._userInfo = {};  // Set by UserManagement after guest login
     }
 
     get type() { return 'download'; }
     get displayName() { return 'Download'; }
-    get canSave() { return true; }
+    get canSave() { return false; }  // In-memory only — no persistent save target; use Save As / download
     get userInfo() { return this._userInfo; }
 
+    /**
+     * Update the stored user info (called from UserManagement after guest login).
+     * @param {Object} info - User info object {id, name, role, color}
+     */
+    setUserInfo(info) {
+        this._userInfo = info;
+    }
+
     async init() {
-        var localUser = localStorage.getItem('frametrail_local_user');
-        if (localUser) {
-            this._userInfo = JSON.parse(localUser);
-        } else {
-            var name = prompt('Enter your name for annotations:', 'Local User');
-            this._userInfo = {
-                id: 'local-' + Date.now(),
-                name: name || 'Local User',
-                role: 'admin',
-                mail: '',
-                registrationDate: Date.now(),
-                color: '#FF9800'
-            };
-            localStorage.setItem('frametrail_local_user', JSON.stringify(this._userInfo));
-        }
         return true;
     }
 

src/_shared/frametrail-core/storage/StorageAdapterLocal.js

@@ -63,12 +63,17 @@ class StorageAdapterLocal extends StorageAdapter {
             await this._scaffoldEmptyProject();
         }
 
-        // Set up local user
-        await this._initLocalUser();
-
         return true;
     }
 
+    /**
+     * Update the stored user info (called from UserManagement after guest login).
+     * @param {Object} info - User info object {id, name, role, color}
+     */
+    setUserInfo(info) {
+        this._userInfo = info;
+    }
+
     /**
      * Create minimum project structure in an empty folder.
      * @private
@@ -94,49 +99,6 @@ class StorageAdapterLocal extends StorageAdapter {
         await this.writeJSON('resources/_index.json', { 'resources': {} });
     }
 
-    /**
-     * Set up local user identity. Prompts for name on first use,
-     * stores in localStorage for subsequent sessions.
-     * @private
-     */
-    async _initLocalUser() {
-        var localUser = localStorage.getItem('frametrail_local_user');
-        if (localUser) {
-            this._userInfo = JSON.parse(localUser);
-        } else {
-            var name = prompt('Enter your name for annotations:', 'Local User');
-            this._userInfo = {
-                id: 'local-' + Date.now(),
-                name: name || 'Local User',
-                role: 'admin',
-                mail: '',
-                registrationDate: Date.now(),
-                color: '#FF9800'
-            };
-            localStorage.setItem('frametrail_local_user', JSON.stringify(this._userInfo));
-        }
-
-        await this._ensureUserInUsersFile();
-    }
-
-    /**
-     * Ensure the local user exists in the local users.json file.
-     * @private
-     */
-    async _ensureUserInUsersFile() {
-        var users;
-        try {
-            users = await this.readJSON('users.json');
-        } catch (e) {
-            users = { 'user-increment': 0, 'user': {} };
-        }
-
-        if (!users.user[this._userInfo.id]) {
-            users.user[this._userInfo.id] = this._userInfo;
-            await this.writeJSON('users.json', users);
-        }
-    }
-
     async readJSON(path) {
         var handle = await this._getFileHandle(path, false);
         var file = await handle.getFile();

src/_shared/modules/Localization/locale/de.js

@@ -370,6 +370,9 @@ window.FrameTrail_L10n['de'] = {
 	"UserColor": "Nutzer:innen-Farbe",
 	"UserCreateAccount": "Account anlegen",
 	"UserDividerOr": "oder",
+	"UserEditAsGuest": "Als Gast bearbeiten",
+	"UserGuestEditNote": "Bearbeiten und exportieren ohne Account. Änderungen können nicht auf dem Server gespeichert werden.",
+	"UserGuestName": "Dein Name",
 	"UserInactive": "Inaktiv",
 	"UserLogin": "Anmelden",
 	"UserLogout": "Abmelden",

src/_shared/modules/Localization/locale/en-US.js

@@ -370,6 +370,9 @@ window.FrameTrail_L10n['en-US'] = {
 	"UserColor": "User Color",
 	"UserCreateAccount": "Create Account",
 	"UserDividerOr": "or",
+	"UserEditAsGuest": "Edit as Guest",
+	"UserGuestEditNote": "Edit and export without an account. Changes cannot be saved to the server.",
+	"UserGuestName": "Your name",
 	"UserInactive": "Inactive",
 	"UserLogin": "Login",
 	"UserLogout": "Logout",

src/_shared/modules/StorageManager/module.js

@@ -179,20 +179,22 @@ FrameTrail.defineModule('StorageManager', function(FrameTrail) {
         if (!_currentAdapter) return false;
 
         if (_currentAdapter.type === 'server') {
-            return FrameTrail.getState('loggedIn');
+            return FrameTrail.getState('loggedIn') &&
+                   !FrameTrail.module('UserManagement').isGuestMode();
         }
         return _currentAdapter.canSave;
     }
 
 
     /**
-     * Check if server save is available (server present and user logged in).
+     * Check if server save is available (server present, user logged in, and not in guest mode).
      * @method canSaveToServer
      * @return {Boolean}
      */
     function canSaveToServer() {
         return FrameTrail.module('RouteNavigation').environment.server &&
-               FrameTrail.getState('loggedIn');
+               FrameTrail.getState('loggedIn') &&
+               !FrameTrail.module('UserManagement').isGuestMode();
     }
 
 
@@ -206,25 +208,6 @@ FrameTrail.defineModule('StorageManager', function(FrameTrail) {
     }
 
 
-    /**
-     * Lazily initialize the Download adapter's user identity.
-     * Called on first edit attempt in download mode.
-     * Checks localStorage; if no user is stored, prompts for a name.
-     *
-     * @method ensureDownloadUser
-     * @return {Promise<Object>} Resolves with the user info object
-     */
-    function ensureDownloadUser() {
-        var info = _downloadAdapter.userInfo;
-        if (info && info.id) {
-            return Promise.resolve(info);
-        }
-        return _downloadAdapter.init().then(function() {
-            return _downloadAdapter.userInfo;
-        });
-    }
-
-
     /**
      * Get current user info from the active adapter.
      * @method getCurrentUserInfo
@@ -263,8 +246,7 @@ FrameTrail.defineModule('StorageManager', function(FrameTrail) {
         canSaveToServer:     canSaveToServer,
         canSaveToLocal:      canSaveToLocal,
         getCurrentUserInfo:  getCurrentUserInfo,
-        getFolderName:       getFolderName,
-        ensureDownloadUser:  ensureDownloadUser
+        getFolderName:       getFolderName
     };
 
 });