Skip to content

Commit 05f8ae2

Browse files
committed
code review changes
1 parent 6aee233 commit 05f8ae2

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

openleadr/client.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ def __init__(self, ven_name, vtn_url, debug=False, cert=None, key=None,
6666
:param str ven_id: The ID for this VEN. If you leave this blank,
6767
a VEN_ID will be assigned by the VTN.
6868
:param bool disable_signature: Whether or not to sign outgoing messages using a public-private key pair in PEM format.
69+
:param bool check_hostname: Whether or not to check hostname
70+
:param int event_status_log_period: Setting the priod of status change logging
71+
:param int events_clean_up_period: Setting the priod of not relevant events clean up
6972
"""
7073

7174
self.ven_name = ven_name
@@ -950,7 +953,7 @@ async def _on_event(self, message):
950953
event_id = event['event_descriptor']['event_id']
951954
event_status = event['event_descriptor']['event_status']
952955
modification_number = event['event_descriptor']['modification_number']
953-
logger.info("The VEN received an event with event_id: %s, status: %s, modification_number: %s", event_id, event_status, modification_number)
956+
logger.info("The VEN received an event with event_id: %s, status: %s, modification_number: %s", event_id, event_status, modification_number) # change to debug
954957
received_event = utils.find_by(self.received_events, 'event_descriptor.event_id', event_id)
955958
if received_event:
956959
if received_event['event_descriptor']['modification_number'] == modification_number:
@@ -1016,12 +1019,12 @@ async def _event_status_log(self):
10161019
for event in self.received_events:
10171020
# ignoring the cancelled case
10181021
if event['event_descriptor']['event_status'] == 'cancelled':
1019-
return
1022+
continue
10201023

10211024
event_status = utils.determine_event_status(event['active_period'])
10221025
if event_status != event['event_descriptor']['event_status']:
10231026
event['event_descriptor']['event_status'] = event_status
1024-
logger.info("event_id: %s has new status: %s", event['event_descriptor']['event_id'], event_status)
1027+
logger.info("event_id: %s has new status: %s", event['event_descriptor']['event_id'], event_status) # change to debug
10251028

10261029
async def _event_cleanup(self):
10271030
"""

0 commit comments

Comments
 (0)