Skip to content

Commit fba2bf7

Browse files
committed
[OMParser] optimise code in make_values()
1 parent f7861b3 commit fba2bf7

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

OMPython/OMParser.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -157,14 +157,9 @@ def make_values(strings, name):
157157
varValue = (varValue.replace('{', '').strip()).replace('}', '').strip()
158158
multiple_values = varValue.split(",")
159159

160-
for n in range(len(multiple_values)):
161-
each_v = multiple_values[n]
162-
multiple_values.pop(n)
163-
each_v = typeCheck(each_v)
164-
multiple_values.append(each_v)
165-
166160
if len(multiple_values) != 0:
167-
result[main_set_name]['Elements'][name]['Properties']['Results'][varName] = multiple_values
161+
multiple_values_type_checked = [typeCheck(val) for val in multiple_values]
162+
result[main_set_name]['Elements'][name]['Properties']['Results'][varName] = multiple_values_type_checked
168163
elif varName != "" and varValue != "":
169164
result[main_set_name]['Elements'][name]['Properties']['Results'][varName] = varValue
170165
else:

0 commit comments

Comments
 (0)