librc: fix resource leaks

williamh · williamh · commit 5ffa1c7fd741 · 2022-05-08T17:10:44.000-05:00
diff --git a/src/librc/librc.c b/src/librc/librc.c
@@ -947,9 +947,11 @@ rc_services_in_runlevel(const char *runlevel)
 
 #ifdef RC_PKG_INITDIR
 		TAILQ_CONCAT(list, pkg, entries);
+		rc_stringlist_free(pkg);
 #endif
 #ifdef RC_LOCAL_INITDIR
 		TAILQ_CONCAT(list, local, entries);
+		rc_stringlist_free(local);
 #endif
 		return list;
 	}
@@ -1007,6 +1009,7 @@ rc_services_in_state(RC_SERVICE state)
 		services = ls_dir(dir, LS_INITD);
 		if (services) {
 			TAILQ_CONCAT(list, services, entries);
+			rc_stringlist_free(services);
 		}
 	}
 	rc_stringlist_free(dirs);

Original file line number	Diff line number	Diff line change
`@@ -947,9 +947,11 @@ rc_services_in_runlevel(const char *runlevel)`
`947`	`947`
`948`	`948`	`#ifdef RC_PKG_INITDIR`
`949`	`949`	`TAILQ_CONCAT(list, pkg, entries);`
	`950`	`+ rc_stringlist_free(pkg);`
`950`	`951`	`#endif`
`951`	`952`	`#ifdef RC_LOCAL_INITDIR`
`952`	`953`	`TAILQ_CONCAT(list, local, entries);`
	`954`	`+ rc_stringlist_free(local);`
`953`	`955`	`#endif`
`954`	`956`	`return list;`
`955`	`957`	`}`
`@@ -1007,6 +1009,7 @@ rc_services_in_state(RC_SERVICE state)`
`1007`	`1009`	`services = ls_dir(dir, LS_INITD);`
`1008`	`1010`	`if (services) {`
`1009`	`1011`	`TAILQ_CONCAT(list, services, entries);`
	`1012`	`+ rc_stringlist_free(services);`
`1010`	`1013`	`}`
`1011`	`1014`	`}`
`1012`	`1015`	`rc_stringlist_free(dirs);`