Merge pull request #56 from OpenSLO/agaurav-dev

[sumo] add timezone support for alert notifications

Author: agaurav

README.md

@@ -58,6 +58,7 @@ alerts:
       notifications: # one or more notification channels
         - connectionType: 'Email'
           recipients: 'youremailid@email.com'
+          timeZone: 'PST'
           triggerFor:
             - Warning
             - ResolvedWarning

libs/monitor.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"sort"
 	"text/template"
+	"time"
 )
 
 type SLOMonitorConfig struct {
@@ -125,6 +126,7 @@ func MonitorConfigFromOpenSLO(sloConf SLO) (*SLOMonitorConfig, error) {
 	for _, alert := range alertTmplParams {
 
 		sortedNotifs := make([]Notification, len(alert.Notifications))
+
 		copy(sortedNotifs, alert.Notifications)
 		sort.Slice(sortedNotifs, func(i, j int) bool {
 			return GiveStructCompare(sortedNotifs[i], sortedNotifs[j])
@@ -175,3 +177,13 @@ func ConvertToBurnRateTmplParams(alerts []BurnRate, target, timesliceTarget floa
 
 	return tmplAlertsParams
 }
+
+func giveLocalTimeZone() string {
+	loc, err := time.LoadLocation("Local")
+
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	return loc.String()
+}

libs/overview.go

@@ -31,7 +31,7 @@ func giveWhereClause(dashVars []string) string {
 
 	var clauses []string
 	for _, v := range dashVars {
-		clauses = append(clauses, fmt.Sprintf("(\"{{%s}}\"=\"*\" or %s=\"{{%s}}\")", v, v, v))
+		clauses = append(clauses, fmt.Sprintf(`( %s matches "{{%s}}" )`, v, v))
 	}
 
 	wherePart := "| where " + strings.Join(clauses, " and ")

libs/templates/terra/monitor.tf.gotf

@@ -55,7 +55,7 @@ QUERY
                 {{end}}
             ]
             subject         = "SLO breach alert: {{$.Service}} - {{$.Name}}"
-            time_zone       = "PST"
+            time_zone       = {{if ne $n.TimeZone "" }}"{{$n.TimeZone}}"{{else}}"PST"{{end}}
             message_body    = "{{`{{Description}} \n Result : {{ResultsJson}}\n Alert: {{AlertResponseURL}}`}}"
             {{else}}
             connection_id   = "{{$n.ConnectionID}}"

samples/logs/drift-calculation.yaml

@@ -36,6 +36,7 @@ alerts:
         - connectionType: 'Email'
           recipients:
             - 'agaurav@sumologic.com'
+          timeZone: 'PST'
           triggerFor:
             - Warning
             - ResolvedWarning

samples/logs/ingest-lag-timeslice-budgeting.yaml

@@ -45,6 +45,7 @@ alerts:
         - connectionType: 'Email'
           recipients:
             - 'agaurav@sumologic.com'
+          timeZone: 'PST'
           triggerFor:
             - Warning
             - ResolvedWarning

samples/logs/trend-calculation.yaml

@@ -40,6 +40,7 @@ alerts:
         - connectionType: 'Email'
           recipients:
             - 'agaurav@sumologic.com'
+          timeZone: 'PST'
           triggerFor:
             - Warning
             - ResolvedWarning
@@ -51,6 +52,7 @@ alerts:
         - connectionType: 'Email'
           recipients:
             - 'agaurav@sumologic.com'
+          timeZone: 'PST'
           triggerFor:
             - Warning
             - ResolvedWarning

samples/tracing/checkout-latency.yaml

@@ -50,6 +50,7 @@ alerts:
         - connectionType: 'Email'
           recipients:
             - 'agaurav@sumologic.com'
+          timeZone: 'PST'
           triggerFor:
             - Warning
             - ResolvedWarning