Implementation of getSessionKeyData for JLP

Author: abhayks1

lib/ContractInteract/TokenHolder.js

@@ -110,6 +110,10 @@ class TokenHolder {
    * @returns {string} Executable data to revoke a session.
    */
   getRevokeSessionExecutableData(sessionKey) {
+    if (!Web3.utils.isAddress(sessionKey)) {
+      const err = new TypeError(`Invalid sessionKey address: ${sessionKey}.`);
+      return Promise.reject(err);
+    }
     return this.contract.methods.revokeSession(sessionKey).encodeABI();
   }
 
@@ -192,10 +196,16 @@ class TokenHolder {
   /**
    * It returns the session key data object.
    *
+   * @param {string} sessionKey Authorized session key address.
+   *
    * @return {Promise<Object>} Promise that resolves current GnosisSafe nonce.
    */
   getSessionKeyData(sessionKey) {
-    return Promise.resolve(this.contract.methods.sessionKeys().call(sessionKey));
+    if (!Web3.utils.isAddress(sessionKey)) {
+      const err = new TypeError(`Invalid sessionKey address: ${sessionKey}.`);
+      return Promise.reject(err);
+    }
+    return Promise.resolve(this.contract.methods.sessionKeys(sessionKey).call());
   }
 }
 

test/unit/TokenHolder/getRevokeSessionExecutableData.js

@@ -5,6 +5,7 @@ const sinon = require('sinon');
 const { assert } = require('chai');
 
 const Spy = require('../../../utils/Spy');
+const AssertAsync = require('../../../utils/AssertAsync');
 const TokenHolder = require('../../../lib/ContractInteract/TokenHolder');
 
 describe('TokenHolder.getAuthorizeSessionWithExecutableData()', () => {
@@ -32,4 +33,9 @@ describe('TokenHolder.getAuthorizeSessionWithExecutableData()', () => {
     assert.strictEqual(response, mockRevokeSession);
     Spy.assert(revokeSessionSpy, 1, [[sessionKey]]);
   });
+
+  it('should throw an error when to address is undefined', async () => {
+    const sessionKey = undefined;
+    await AssertAsync.reject(tokenHolder.getSessionKeyData(sessionKey), `Invalid sessionKey address: undefined.`);
+  });
 });

test/unit/TokenHolder/getSessionKeyData.js

@@ -5,9 +5,10 @@ const sinon = require('sinon');
 const { assert } = require('chai');
 
 const Spy = require('../../../utils/Spy');
+const AssertAsync = require('../../../utils/AssertAsync');
 const TokenHolder = require('../../../lib/ContractInteract/TokenHolder');
 
-describe('TokenHolder.getLogoutExecutableData()', () => {
+describe('TokenHolder.getSessionKeyData()', () => {
   let tokenHolder;
 
   beforeEach(() => {
@@ -17,17 +18,24 @@ describe('TokenHolder.getLogoutExecutableData()', () => {
   });
 
   it('should construct with correct parameters', async () => {
+    const sessionKey = '0x0000000000000000000000000000000000000003';
+
     const mockSessionKeyData = 'mockSessionKeyData';
-    const logoutSpy = sinon.replace(
+    const sessionKeyDataSpy = sinon.replace(
       tokenHolder.contract.methods,
       'sessionKeys',
       sinon.fake.returns({
         call: () => Promise.resolve(mockSessionKeyData)
       })
     );
-    const response = await tokenHolder.getSessionKeyData();
+    const response = await tokenHolder.getSessionKeyData(sessionKey);
 
     assert.strictEqual(response, mockSessionKeyData);
-    Spy.assert(logoutSpy, 1, [[]]);
+    Spy.assert(sessionKeyDataSpy, 1, [[sessionKey]]);
+  });
+
+  it('should throw an error when to address is undefined', async () => {
+    const sessionKey = undefined;
+    await AssertAsync.reject(tokenHolder.getSessionKeyData(sessionKey), `Invalid sessionKey address: undefined.`);
   });
 });