Skip to content

Commit 5db2f2c

Browse files
OpenSource03claude
andcommitted
fix: strip electron-liquid-glass from Windows and Linux CI manifests
The macOS-only native dependency was still being compiled by @electron/rebuild on non-macOS runners. Remove it from the manifest alongside the postinstall hook, and use --no-frozen-lockfile so pnpm regenerates the lockfile without the stripped dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9dd8b44 commit 5db2f2c

1 file changed

Lines changed: 19 additions & 8 deletions

File tree

.github/workflows/build.yml

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,17 +118,18 @@ jobs:
118118
node-version: 22
119119
cache: pnpm
120120

121-
- name: Disable root postinstall for Windows CI
121+
- name: Strip mac-only native dependency from Windows CI manifest
122122
shell: bash
123123
run: |
124-
# electron-builder already rebuilds native deps during packaging.
125-
# Skip the repo's dev-focused postinstall hook here because on
126-
# Windows it still tries to compile the macOS-only
127-
# electron-liquid-glass module and fails the job before packaging.
128-
node -e "const fs=require('fs'); const pkg=require('./package.json'); delete pkg.scripts.postinstall; fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n');"
124+
# electron-builder rebuilds native prod deps during packaging.
125+
# On Windows, remove the macOS-only electron-liquid-glass package so
126+
# @electron/rebuild never tries to compile Objective-C++ sources.
127+
# Also drop the root postinstall because this CI job does not need
128+
# the repo's dev-focused rebuild hook.
129+
node -e "const fs=require('fs'); const pkg=require('./package.json'); delete pkg.scripts.postinstall; delete pkg.dependencies['electron-liquid-glass']; fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n');"
129130
130131
- name: Install dependencies
131-
run: pnpm install
132+
run: pnpm install --no-frozen-lockfile
132133

133134
- name: Build app
134135
run: pnpm build
@@ -179,8 +180,18 @@ jobs:
179180
sudo apt-get update
180181
sudo apt-get install -y build-essential python3 libsecret-1-dev libnotify-dev
181182
183+
- name: Strip mac-only native dependency from Linux CI manifest
184+
shell: bash
185+
run: |
186+
# electron-builder rebuilds native prod deps during packaging.
187+
# On Linux, remove the macOS-only electron-liquid-glass package so
188+
# @electron/rebuild never tries to compile Objective-C++ sources.
189+
# Also drop the root postinstall because this CI job does not need
190+
# the repo's dev-focused rebuild hook.
191+
node -e "const fs=require('fs'); const pkg=require('./package.json'); delete pkg.scripts.postinstall; delete pkg.dependencies['electron-liquid-glass']; fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n');"
192+
182193
- name: Install dependencies
183-
run: pnpm install
194+
run: pnpm install --no-frozen-lockfile
184195

185196
- name: Build app
186197
run: pnpm build

0 commit comments

Comments
 (0)