[smarcet]

smarcet · smarcet · commit 23bd5c262e52 · 2017-10-12T15:25:45.000-03:00
* survey test group - fixed logic
diff --git a/survey_builder/code/infrastructure/active_records/instances/Survey.php b/survey_builder/code/infrastructure/active_records/instances/Survey.php
@@ -65,10 +65,9 @@ class Survey extends DataObject implements ISurvey
     protected function onBeforeWrite()
     {
         parent::onBeforeWrite();
+        // only force IsTest if belongs to Group SurveyTestersGroupSlug
         if ($this->CreatedBy()->inGroup(Survey::SurveyTestersGroupSlug)) {
             $this->IsTest = true;
-        } else {
-            $this->IsTest = false;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -65,10 +65,9 @@ class Survey extends DataObject implements ISurvey`
`65`	`65`	`protected function onBeforeWrite()`
`66`	`66`	`{`
`67`	`67`	`parent::onBeforeWrite();`
	`68`	`+ // only force IsTest if belongs to Group SurveyTestersGroupSlug`
`68`	`69`	`if ($this->CreatedBy()->inGroup(Survey::SurveyTestersGroupSlug)) {`
`69`	`70`	`$this->IsTest = true;`
`70`		`- } else {`
`71`		`- $this->IsTest = false;`
`72`	`71`	`}`
`73`	`72`	`}`
`74`	`73`