[smarcet] - #13793

* moved default event types to flag on DB

Author: smarcet

migrations/migrations.yml

@@ -98,4 +98,5 @@ migrations:
   - RepublishElectionPagesMigration
   - AddOnDeleteCascadeForEventsAndPresentationMaterials
   - AddSummitCalendarSyncErrorEmailMigration
+  - RefactorDefaultEventTypesMigration
 

summit/code/infrastructure/active_records/Summit.php

@@ -1072,6 +1072,7 @@ public static function seedBasicEventTypes($summit_id)
         $presentation->AreSpeakersMandatory = false;
         $presentation->UseModerator = false;
         $presentation->IsModeratorMandatory = false;
+        $presentation->IsDefault = true;
         $presentation->write();
 
         $key_note = SummitEventType::get()->filter(['Type' => IPresentationType::Keynotes, 'SummitID' => $summit_id])->first();
@@ -1090,6 +1091,7 @@ public static function seedBasicEventTypes($summit_id)
         $key_note->AreSpeakersMandatory   = false;
         $key_note->UseModerator           = true;
         $key_note->IsModeratorMandatory   = false;
+        $key_note->IsDefault = true;
         $key_note->write();
 
         $panel = SummitEventType::get()->filter(['Type' => IPresentationType::Panel, 'SummitID' => $summit_id])->first();
@@ -1108,6 +1110,7 @@ public static function seedBasicEventTypes($summit_id)
         $panel->AreSpeakersMandatory   = false;
         $panel->UseModerator           = true;
         $panel->IsModeratorMandatory   = false;
+        $panel->IsDefault = true;
         $panel->write();
 
         $lighting_talks = SummitEventType::get()->filter(['Type' => IPresentationType::LightingTalks, 'SummitID' => $summit_id])->first();
@@ -1126,6 +1129,7 @@ public static function seedBasicEventTypes($summit_id)
         $lighting_talks->AreSpeakersMandatory = false;
         $lighting_talks->UseModerator = false;
         $lighting_talks->IsModeratorMandatory = false;
+        $lighting_talks->IsDefault = true;
         $lighting_talks->write();
 
         $hand_on_labs = SummitEventType::get()->filter(['Type' => ISummitEventType::HandonLabs, 'SummitID' => $summit_id])->first();
@@ -1136,6 +1140,7 @@ public static function seedBasicEventTypes($summit_id)
 
         $hand_on_labs->Type = ISummitEventType::HandonLabs;
         $hand_on_labs->SummitID = $summit_id;
+        $hand_on_labs->IsDefault = true;
         $hand_on_labs->write();
 
         $lunch = SummitEventType::get()->filter(['Type' => ISummitEventType::Lunch, 'SummitID' => $summit_id])->first();
@@ -1145,6 +1150,7 @@ public static function seedBasicEventTypes($summit_id)
 
         $lunch->Type = ISummitEventType::Lunch;
         $lunch->SummitID = $summit_id;
+        $lunch->IsDefault = true;
         $lunch->write();
 
         $breaks = SummitEventType::get()->filter(['Type' => ISummitEventType::Breaks, 'SummitID' => $summit_id])->first();
@@ -1154,16 +1160,17 @@ public static function seedBasicEventTypes($summit_id)
 
         $breaks->Type = ISummitEventType::Breaks;
         $breaks->SummitID = $summit_id;
+        $breaks->IsDefault = true;
         $breaks->write();
 
-
         $evening_events = SummitEventType::get()->filter(['Type' => ISummitEventType::EveningEvents, 'SummitID' => $summit_id])->first();
         if (is_null($evening_events)) {
             $evening_events = new SummitEventType();
         }
 
         $evening_events->Type     = ISummitEventType::EveningEvents;
         $evening_events->SummitID = $summit_id;
+        $breaks->IsDefault = true;
         $evening_events->write();
 
 
@@ -1172,26 +1179,12 @@ public static function seedBasicEventTypes($summit_id)
             $groups_events = new SummitEventType();
         }
 
-        $groups_events->Type     = ISummitEventType::GroupsEvents;
-        $groups_events->SummitID = $summit_id;
+        $groups_events->Type      = ISummitEventType::GroupsEvents;
+        $groups_events->SummitID  = $summit_id;
+        $groups_events->IsDefault = true;
         $groups_events->write();
     }
 
-    public static function isDefaultEventType($event_type)
-    {
-        return in_array($event_type,
-            [
-                IPresentationType::Presentation,
-                IPresentationType::Keynotes,
-                IPresentationType::Panel,
-                IPresentationType::LightingTalks,
-                ISummitEventType::HandonLabs,
-                ISummitEventType::EveningEvents,
-                ISummitEventType::Lunch_Breaks,
-                ISummitEventType::GroupsEvents,
-            ]);
-    }
-
     /**
      * @return bool
      */

summit/code/infrastructure/active_records/events/SummitEventType.php

@@ -25,30 +25,24 @@ class SummitEventType extends DataObject implements ISummitEventType
         'UseSponsors'          => 'Boolean',
         'AreSponsorsMandatory' => 'Boolean',
         'AllowsAttachment'     => 'Boolean',
+        'IsDefault'            => 'Boolean',
     );
 
-    private static $has_many = array
-    (
-    );
+    private static $has_many = [];
 
-    private static $defaults = array
-    (
-    );
+    private static $defaults = [];
 
-    private static $has_one = array
-    (
+    private static $has_one = [
         'Summit' => 'Summit'
-    );
+    ];
 
-    private static $summary_fields = array
-    (
+    private static $summary_fields = [
         'Type'
-    );
+    ];
 
-    private static $searchable_fields = array
-    (
+    private static $searchable_fields = [
         'Type'
-    );
+    ];
     /**
      * @return int
      */
@@ -74,7 +68,7 @@ public function getBlackoutTimes()
     }
 
     public function canDelete($member=null) {
-        if (Summit::isDefaultEventType($this->Type))
+        if ($this->IsDefault)
         {
             return false;
         }
@@ -84,7 +78,7 @@ public function canDelete($member=null) {
     public function getCMSFields() {
         $fields = new FieldList();
         $fields->add($type_txt = new TextField('Type','Type'));
-        if($this->ID > 0  && Summit::isDefaultEventType($this->Type))
+        if($this->ID > 0  && $this->IsDefault)
         {
             $type_txt->setReadonly(true);
         }

summit/code/migrations/RefactorDefaultEventTypesMigration.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Copyright 2018 OpenStack Foundation
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ **/
+
+/**
+ * Class RefactorDefaultEventTypesMigration
+ */
+final class RefactorDefaultEventTypesMigration extends AbstractDBMigrationTask
+{
+    protected $title = "RefactorDefaultEventTypesMigration";
+
+    protected $description = "RefactorDefaultEventTypesMigration";
+
+    function doUp()
+    {
+        $default_types = [
+            IPresentationType::Presentation,
+            IPresentationType::Keynotes,
+            IPresentationType::Panel,
+            IPresentationType::LightingTalks,
+            ISummitEventType::HandonLabs,
+            ISummitEventType::EveningEvents,
+            ISummitEventType::Lunch_Breaks,
+            ISummitEventType::GroupsEvents,
+        ];
+
+        $sql = <<<SQL
+       UPDATE SummitEventType SET IsDefault = 1 WHERE Type IN (
+       '%s'
+       )
+SQL;
+
+        DB::query(sprintf($sql, implode("','",$default_types)));
+
+    }
+
+    function doDown()
+    {
+        // TODO: Implement doDown() method.
+    }
+}