Skip to content

Commit ba67762

Browse files
committed
[spalenque] - #14400 * add space between links
1 parent 69fca46 commit ba67762

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

software/code/tasks/IngestOpenStackComponentsDataCronTask.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,7 @@ private function processComponentsAndCategories()
385385

386386
if (isset($component['links'])) {
387387
foreach ($component['links'] as $linkArray) {
388+
if (!is_array($linkArray)) continue;
388389
foreach ($linkArray as $label => $link) {
389390
$linkObj = OpenStackComponentLink::get()->filter(['Label' => $label, 'URL' => $link])->First();
390391

software/templates/Layout/SoftwareHomePage_getComponent.ss

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@
1818
<% if $Component.DocsLink().Exists() %>
1919
<p>
2020
<a href="{$Component.DocsLink().URL}" target="_blank">
21-
<i class="fa fa-book" aria-hidden="true"></i>
22-
{$Component.DocsLink().Label}
21+
<%-- do not separate icon from label --%>
22+
<i class="fa fa-book" aria-hidden="true" style="margin-right: 8px"></i><span>{$Component.DocsLink().Label}</span>
2323
</a>
2424
</p>
2525
<% end_if %>
2626
<% if $Component.DownloadLink().Exists() %>
2727
<p>
2828
<a href="{$Component.DownloadLink().URL}" target="_blank">
29-
<i class="fa fa-cloud-download" aria-hidden="true"></i>
30-
{$Component.DownloadLink().Label}
29+
<%-- do not separate icon from label --%>
30+
<i class="fa fa-cloud-download" aria-hidden="true" style="margin-right: 8px"></i><span>{$Component.DownloadLink().Label}</span>
3131
</a>
3232
</p>
3333
<% end_if %>
@@ -58,6 +58,7 @@
5858
<div class="col-sm-12">
5959
<% loop $Component.Links() %>
6060
<a class="component-link" href="{$URL}">{$Label}</a>
61+
<% if not $Last %><span style="margin-right:10px">|</span><% end_if %>
6162
<% end_loop %>
6263
</div>
6364
</div>

0 commit comments

Comments
 (0)