fix(login): wrong encoding issue on backUrl param

Author: smarcet

src/components/security/methods.js

@@ -2,7 +2,6 @@ import {
     base64URLEncode,
     getAuthCallback,
     getCurrentLocation,
-    getCurrentPathName,
     getFromLocalStorage,
     removeFromLocalStorage,
     getOrigin,
@@ -14,8 +13,24 @@ import moment from "moment-timezone";
 import request from 'superagent/lib/client';
 import SuperTokensLock from 'browser-tabs-lock';
 import Cookies from 'js-cookie'
-
 let http = request;
+import URI from "urijs";
+import IdTokenVerifier from "idtoken-verifier";
+import {SET_LOGGED_USER} from "./actions";
+import {getRandomBytes, getSHA256} from "../../utils/crypto";
+
+import {
+    AUTH_ERROR_ACCESS_TOKEN_EXPIRED,
+    AUTH_ERROR_MISSING_AUTH_INFO,
+    AUTH_ERROR_MISSING_REFRESH_TOKEN,
+    AUTH_ERROR_LOCK_ACQUIRE_ERROR,
+    AUTH_ERROR_REFRESH_TOKEN_REQUEST_ERROR,
+    AUTH_ERROR_REFRESH_TOKEN_NETWORK_ERROR,
+    AUTH_ERROR_ID_TOKEN_INVALID,
+    AUTH_ERROR_MISSING_OTP_PARAM,
+    AUTH_ERROR_MISSING_PKCE_PARAM,
+    AUTH_ERROR_MISSING_NONCE_PARAM,
+} from "./constants";
 
 /**
  * @ignore
@@ -34,24 +49,8 @@ const AUTH_INFO = 'authInfo';
 const NONCE = 'nonce';
 const PKCE = 'pkce';
 const ID_TOKEN = 'idToken';
+const BACK_ULR_PARAM_NAME = 'BackUrl';
 
-import URI from "urijs";
-import IdTokenVerifier from "idtoken-verifier";
-import {SET_LOGGED_USER} from "./actions";
-import {getRandomBytes, getSHA256} from "../../utils/crypto";
-
-import {
-    AUTH_ERROR_ACCESS_TOKEN_EXPIRED,
-    AUTH_ERROR_MISSING_AUTH_INFO,
-    AUTH_ERROR_MISSING_REFRESH_TOKEN,
-    AUTH_ERROR_LOCK_ACQUIRE_ERROR,
-    AUTH_ERROR_REFRESH_TOKEN_REQUEST_ERROR,
-    AUTH_ERROR_REFRESH_TOKEN_NETWORK_ERROR,
-    AUTH_ERROR_ID_TOKEN_INVALID,
-    AUTH_ERROR_MISSING_OTP_PARAM,
-    AUTH_ERROR_MISSING_PKCE_PARAM,
-    AUTH_ERROR_MISSING_NONCE_PARAM,
-} from "./constants";
 
 /**
  *
@@ -62,6 +61,7 @@ import {
  * @param loginHint
  * @param otpLoginHint
  * @param tenant
+ * @param backUrlParamName
  * @returns {*}
  */
 export const getAuthUrl = (
@@ -71,7 +71,9 @@ export const getAuthUrl = (
     provider = null,
     loginHint = null,
     otpLoginHint = null,
-    tenant = null) => {
+    tenant = null,
+    backUrlParamName = BACK_ULR_PARAM_NAME
+    ) => {
 
     let oauth2ClientId = getOAuth2ClientId();
     let redirectUri = getAuthCallback();
@@ -80,7 +82,7 @@ export const getAuthUrl = (
     let flow = getOAuth2Flow();
 
     if (backUrl != null)
-        redirectUri += `?BackUrl=${encodeURI(backUrl)}`;
+        redirectUri += `?${backUrlParamName}=${encodeURIComponent(backUrl)}`;
 
     let nonce = createNonce(NONCE_LEN);
 
@@ -222,7 +224,14 @@ const createPKCECodes = () => {
     return codePair
 }
 
-export const emitAccessToken = async (code, backUrl = null) => {
+/**
+
+ * @param code
+ * @param backUrl
+ * @param backUrlParamName
+ * @returns {Promise<{access_token: *, refresh_token: *, id_token: *, expires_in: *, error: *, error_description: *}>}
+ */
+export const emitAccessToken = async (code, backUrl = null, backUrlParamName = BACK_ULR_PARAM_NAME) => {
 
     let baseUrl = getOAuth2IDPBaseUrl();
     let oauth2ClientId = getOAuth2ClientId();
@@ -233,7 +242,7 @@ export const emitAccessToken = async (code, backUrl = null) => {
         throw Error(AUTH_ERROR_MISSING_PKCE_PARAM);
 
     if (backUrl != null)
-        redirectUri += `?BackUrl=${encodeURI(backUrl)}`;
+        redirectUri += `?${backUrlParamName}=${encodeURIComponent(backUrl)}`;
 
     const payload = {
         'code': code,