Commit 19e5f53
fix(promo-codes): fix serializer tests and resolve D3 deviation
Serializer unit tests (testSerializerAutoApplyField,
testSerializerRemainingQuantityPerAccount, testSerializerAutoApplyEmailLinkedType)
were failing because bare model instances lacked a Summit association, causing
getSummitId() to call getId() on null. Added buildMockSummitForSerializer()
helper and setSummit() calls in all three tests. Updated D3 deviation status
to RESOLVED — AllowedEmailDomainsArray custom rule was already implemented.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>1 parent ed2064d commit 19e5f53
6 files changed
Lines changed: 116 additions & 91 deletions
File tree
- app
- ModelSerializers/Summit/Registration/PromoCodes
- Repositories/Summit
- doc
- tests
- Unit/Services
- oauth2
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
701 | 701 | | |
702 | 702 | | |
703 | 703 | | |
704 | | - | |
705 | | - | |
| 704 | + | |
| 705 | + | |
706 | 706 | | |
707 | 707 | | |
708 | 708 | | |
| |||
0 commit comments