fix(errors): exception processing at JSON endpoints

Author: smarcet

app/Exceptions/Handler.php

@@ -66,6 +66,12 @@ public function render($request, Throwable $e)
         if (config('app.debug')) {
             return parent::render($request, $e);
         }
-        return response()->view('errors.404', [], 200);
+
+        if ($request->expectsJson() || $request->is('api/*')) {
+            $status = $this->isHttpException($e) ? $e->getStatusCode() : 500;
+            return response()->json(['message' => 'server error'], $status);
+        }
+
+        return response()->view('errors.404', [], 404);
     }
 }

app/Http/Controllers/JsonController.php

@@ -27,7 +27,7 @@ public function __construct()
     {
     }
 
-    protected function error500(Exception $ex)
+    protected function error500(\Throwable $ex)
     {
         Log::error($ex);
 

app/Http/Controllers/Utils/RequestProcessor.php

@@ -67,5 +67,9 @@ public function processRequest(Closure $callback){
             Log::error($ex);
             return $this->error500($ex);
         }
+        catch (\Throwable $ex) {
+            Log::error($ex);
+            return $this->error500($ex);
+        }
     }
 }