fix: missing filter at badge scans csv export

Signed-off-by: romanetar <roman_ag@hotmail.com>

Author: romanetar

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeScanApiController.php

@@ -510,7 +510,7 @@ function($filter) use($summit, $current_member){
                     if (!is_null($current_member)){
                         if ($current_member->isAuthzFor($summit)) return $filter;
                         // add filter for sponsor user
-                        if ($current_member->isSponsorUser()) {
+                        if ($current_member->isSponsorUser() || $current_member->isExternalSponsorUser()) {
                             $sponsor_ids = $current_member->getSponsorMembershipIds($summit);
                             // is allowed sponsors are empty, add dummy value
                             if (!count($sponsor_ids)) $sponsor_ids[] = 0;

tests/oauth2/OAuth2SummitBadgeScanApiControllerTest.php

@@ -109,7 +109,7 @@ public function testAddEncryptedBadgeScan(){
         $this->assertEquals($badge->getId(), $badge_scan->badge_id);
     }
 
-    public function testAddBadgeScanWithOneSponsorsPerMember(){
+    public function testAddBadgeScanWithOneSponsorPerMember(){
         self::$member->clearGroups();
         self::$member->add2Group($this->sponsor_group);
         self::$em->persist(self::$member);
@@ -391,7 +391,7 @@ public function testAddBadgeScanWithMultipleSponsorsWithSponsorId()
     }
 
     public function testUpdateBadgeScan(){
-        $scan = $this->testAddBadgeScanWithOneSponsorsPerMember();
+        $scan = $this->testAddBadgeScanWithOneSponsorPerMember();
 
         $params = [
             'id' => self::$summit->getId(),
@@ -510,7 +510,7 @@ public function testGetAllSummitBadgeScans(){
     }
 
     public function testGetSummitBadgeScan(){
-        $badge_scan = $this->testAddBadgeScanWithOneSponsorsPerMember();
+        $badge_scan = $this->testAddBadgeScanWithOneSponsorPerMember();
 
         $params = [
             'id'      =>  self::$summit->getId(),
@@ -537,7 +537,7 @@ public function testGetSummitBadgeScan(){
 
     public function testExportSummitBadgeScans(){
 
-        $this->testAddBadgeScanWithOneSponsorsPerMember();
+        $this->testAddBadgeScanWithOneSponsorPerMember();
 
         $params = [
             'id'    =>  self::$summit->getId(),
@@ -561,7 +561,7 @@ public function testExportSummitBadgeScans(){
 
     public function testExportSummitBadgeScansWithReportSettingsRestriction(){
 
-        $this->testAddBadgeScanWithOneSponsorsPerMember();
+        $this->testAddBadgeScanWithOneSponsorPerMember();
 
         $sponsor = self::$summit->getSummitSponsors()[0];
         if (!$sponsor instanceof Sponsor) self::fail();
@@ -622,7 +622,7 @@ public function testExportSummitBadgeScansWithReportSettingsRestriction(){
 
     public function testExportSummitBadgeScansWithAllReportSettingsRestriction(){
 
-        $this->testAddBadgeScanWithOneSponsorsPerMember();
+        $this->testAddBadgeScanWithOneSponsorPerMember();
 
         $sponsor = self::$summit->getSummitSponsors()[0];
         if (!$sponsor instanceof Sponsor) self::fail();