Skip to content

Commit a5809af

Browse files
caseylockerclaude
andcommitted
docs(promo-codes): add Task 11 review follow-up notes
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 82a28c3 commit a5809af

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

doc/promo-codes-for-early-registration-access.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -799,7 +799,8 @@ Deviations from the SDS captured during implementation. Each entry is either **O
799799
- API test: verify a speaker promo code is returned in discovery when email matches, with correct `auto_apply` value in response
800800

801801
**Review Follow-ups:**
802-
- None
802+
- **NIT 1 (pre-existing, tech debt):** Missing `break` after `case 'speaker':` in both `SpeakerSummitRegistrationPromoCodeSerializer.php` and `SpeakerSummitRegistrationDiscountCodeSerializer.php`. When `?expand=speaker` is requested, control falls through to `case 'owner_name':`, adding `owner_name` to the response as an unintended side effect. Not introduced by Task 11 — pre-existing in original code. Fix opportunistically before merge.
803+
- **NIT 2 (out of scope, non-blocking):** All four member/speaker serializers unconditionally set `$values['remaining_quantity_per_account'] = null` (last line before `return`). Not in Task 11 DoD — added during Task 9 discovery work to normalize the response shape across all discovery result types. Semantically correct (null = no per-account limit for these types). No action required.
803804

804805
---
805806

0 commit comments

Comments
 (0)