fix(doctrine): resolve cyclic dep

Author: smarcet

app/Services/Model/ISpeakerService.php

@@ -86,7 +86,7 @@ public function merge(PresentationSpeaker $speaker_from, PresentationSpeaker $sp
      * @throws EntityNotFoundException
      * @return void
      */
-    public function deleteSpeaker($speaker_id);
+    public function deleteSpeaker(int $speaker_id):void;
 
     /**
      * @param Summit $summit
@@ -205,4 +205,4 @@ public function sendEmails(int $summit_id, array $payload, Filter $filter = null
      * @return PresentationSpeaker|null
      */
     public function getSpeakerByMember(Member $member):?PresentationSpeaker;
-}
+}

app/Services/Model/Imp/SpeakerService.php

@@ -762,13 +762,20 @@ public function merge(PresentationSpeaker $speaker_from, PresentationSpeaker $sp
      * @throws EntityNotFoundException
      * @throws ValidationException
      */
-    public function deleteSpeaker($speaker_id)
+    public function deleteSpeaker(int $speaker_id):void
     {
-        return $this->tx_service->transaction(function () use ($speaker_id) {
+        $this->tx_service->transaction(function () use ($speaker_id) {
             $speaker = $this->speaker_repository->getById($speaker_id);
-            if (is_null($speaker))
+            if (!$speaker instanceof PresentationSpeaker::class)
                 throw new EntityNotFoundException;
 
+            // Break circular FK reference to avoid Doctrine CycleDetectedException:
+            // PresentationSpeaker.RegistrationRequestID -> SpeakerRegistrationRequest
+            // SpeakerRegistrationRequest.SpeakerID -> PresentationSpeaker
+            if ($speaker->hasRegistrationRequest()) {
+                $speaker->getRegistrationRequest()->clearSpeaker();
+            }
+
             $this->speaker_repository->delete($speaker);
         });
     }
@@ -1404,4 +1411,4 @@ public function getSpeakerByMember(Member $member): ?PresentationSpeaker
             return $speaker;
         });
     }
-}
+}