feat: Add configurable visibility timeout renewal (MassTransit#6173)

* feat: Add configurable visibility timeout extension

Author: sukanta1991

src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs

@@ -121,7 +121,7 @@ TimeSpan CalculateDelay(int timeout)
 
         var delay = CalculateDelay(visibilityTimeout);
 
-        visibilityTimeout = Math.Min(60, visibilityTimeout);
+        visibilityTimeout = Math.Min(_settings.MaxVisibilityTimeoutRenewal, visibilityTimeout);
 
         while (_locked && !_activeTokenSource.IsCancellationRequested)
         {

src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs

@@ -106,6 +106,12 @@ public override IEnumerable<ValidationResult> Validate()
         var visibilityTimeout = TimeSpan.FromSeconds(_settings.VisibilityTimeout);
         if (_settings.MaxVisibilityTimeout < visibilityTimeout)
             yield return this.Failure("MaxVisibilityTimeout", "Must be greater than or equal to VisibilityTimeout");
+        
+        if (_settings.MaxVisibilityTimeoutRenewal < 0)
+            yield return this.Failure("MaxVisibilityTimeoutRenewal", "must be >= 0 (values less than 60 will be set to 60)");
+
+        if (_settings.MaxVisibilityTimeoutRenewal > 43200)
+            yield return this.Failure("MaxVisibilityTimeoutRenewal", "must be <= 43200 seconds (12 hours per AWS SQS limits)");
 
         foreach (var result in base.Validate())
             yield return result.WithParentKey(queueName);
@@ -168,6 +174,11 @@ public TimeSpan MaxVisibilityTimeout
         set => _settings.MaxVisibilityTimeout = value > MaxAllowedVisibilityTimeout ? MaxAllowedVisibilityTimeout : value;
     }
 
+    public int MaxVisibilityTimeoutRenewal
+    {
+        set => _settings.MaxVisibilityTimeoutRenewal = value < 60 ? 60 : value;
+    }
+
     public void Subscribe<T>(Action<IAmazonSqsTopicSubscriptionConfigurator>? configure = null)
         where T : class
     {

src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/ReceiveSettings.cs

@@ -51,6 +51,13 @@ public interface ReceiveSettings :
     /// </summary>
     int RedeliverVisibilityTimeout { get; set; }
 
+    /// <summary>
+    /// The number of seconds to extend the visibility timeout when renewing message visibility during processing.
+    /// Must be at least 60 seconds per AWS SQS API constraints.
+    /// See <see href="https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ChangeMessageVisibility.html">ChangeMessageVisibility</see>.
+    /// </summary>
+    int MaxVisibilityTimeoutRenewal { get; set; }
+
     string? QueueUrl { get; set; }
 
     /// <summary>

src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Topology/QueueReceiveSettings.cs

@@ -19,6 +19,7 @@ public QueueReceiveSettings(IAmazonSqsEndpointConfiguration configuration, strin
         VisibilityTimeout = 30;
         RedeliverVisibilityTimeout = 1;
         MaxVisibilityTimeout = TimeSpan.FromHours(12);
+        MaxVisibilityTimeoutRenewal = 60;
 
         ConcurrentDeliveryLimit = 1;
 
@@ -43,6 +44,8 @@ public QueueReceiveSettings(IAmazonSqsEndpointConfiguration configuration, strin
 
     public TimeSpan MaxVisibilityTimeout { get; set; }
 
+    public int MaxVisibilityTimeoutRenewal { get; set; }
+
     public string? QueueUrl { get; set; }
 
     public Uri GetInputAddress(Uri hostAddress)

src/Transports/MassTransit.AmazonSqsTransport/Configuration/IAmazonSqsReceiveEndpointConfigurator.cs

@@ -32,6 +32,14 @@ public interface IAmazonSqsReceiveEndpointConfigurator :
     /// </summary>
     public TimeSpan MaxVisibilityTimeout { set; }
 
+    /// <summary>
+    /// Sets the number of seconds to extend the visibility timeout when renewing message visibility during processing.
+    /// Values less than 60 will be set to 60 seconds (AWS SQS minimum for ChangeMessageVisibility).
+    /// Defaults to 60 seconds.
+    /// See <see href="https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ChangeMessageVisibility.html">ChangeMessageVisibility</see>.
+    /// </summary>
+    int MaxVisibilityTimeoutRenewal { set; }
+
     /// <summary>
     /// Bind an existing exchange for the message type to the receive endpoint by name
     /// </summary>