Bump minimum shell agent version from 1.2.0 to 1.2.1

The shell agent 1.2.0 release was broken, so 1.2.1 is now the working
minimum version.

Author: nmburgan

docs/choria-transport-dev.md

@@ -60,7 +60,7 @@ gem, which provides `MCollective::RPC::Client`. Despite the MCollective name
 - **shell**: A separate plugin
   ([choria-plugins/shell-agent](https://github.com/choria-plugins/shell-agent)).
   Provides synchronous (`run`) and asynchronous (`start`/`list`/`statuses`/`kill`)
-  command execution. Version 1.2.0+ required for the batched `statuses` action.
+  command execution. Version 1.2.1+ required for the batched `statuses` action.
 
 ## File Layout
 
@@ -93,7 +93,7 @@ identity. Each entry stores `{ agents: [...], os: 'redhat'|'windows'|... }`.
 The cache lives for the transport instance's lifetime. Non-responding targets
 are not cached (intentional, to allow retry on transient failures).
 
-Agent versions are checked against `AGENT_MIN_VERSIONS` (e.g., shell >= 1.2.0).
+Agent versions are checked against `AGENT_MIN_VERSIONS` (e.g., shell >= 1.2.1).
 Agents below the minimum are excluded from the cache and logged as warnings.
 
 ### RPC Request Pipeline
@@ -368,7 +368,7 @@ error. This is simpler and more predictable than a try-and-fallback approach.
 
 Shell polling uses `shell.list` + `shell.statuses` instead of per-handle
 `shell.status` calls. This reduces RPC overhead from O(N) per round to O(1)
-per target node, making it feasible at scale. This is why version 1.2.0
+per target node, making it feasible at scale. This is why version 1.2.1
 of the shell agent is required, since this is the version version to include
 `shell.statuses`.
 

docs/choria-transport-plan.md

@@ -23,7 +23,7 @@ which Choria agents are available on the remote nodes:
 | Phase | Agents Required | Capabilities Added |
 |-------|----------------|-------------------|
 | Phase 1 | bolt_tasks (ships with Choria+Puppet) | `run_task` (OpenVox/Puppet Server tasks only) |
-| Phase 2 | shell >= 1.2.0 (separate install) | `run_command`, `run_script`, `run_task` (local tasks) |
+| Phase 2 | shell >= 1.2.1 (separate install) | `run_command`, `run_script`, `run_task` (local tasks) |
 | Phase 3 | bolt_tasks | [foreman_openbolt](https://github.com/overlookinfra/foreman_openbolt) and [smart_proxy_openbolt](https://github.com/overlookinfra/smart_proxy_openbolt) Choria transport support (bolt_tasks only) |
 | Phase 4 | file-transfer (new, to be written) | `upload`, `download` (any size, chunked) |
 | Phase 5 | (all above) | Full plan support including apply blocks |

docs/choria-transport-testing.md

@@ -221,10 +221,10 @@ mod 'choria-mcollective', :latest
 mod 'choria-mcollective_choria', :latest
 mod 'mcollective_agent_shell',
   git: 'https://github.com/choria-plugins/shell-agent',
-  ref: '1.2.0'
+  ref: '1.2.1'
 ```
 
-The shell agent requires version 1.2.0 or later (for the batched `statuses`
+The shell agent requires version 1.2.1 or later (for the batched `statuses`
 action). The `bolt_tasks` agent is included in a standard Choria install and
 does not need a separate Puppetfile entry.
 

docs/choria-transport.md

@@ -24,7 +24,7 @@ For test environment setup, see [choria-transport-testing.md](choria-transport-t
 - A Choria client config file on the OpenBolt controller
 - At least one of the supported agents installed on target nodes:
   - **bolt_tasks** (ships with Puppet-enabled Choria setups)
-  - **shell** (separate install, version 1.2.0 or later)
+  - **shell** (separate install, version 1.2.1 or later)
 
 ## Configuration
 
@@ -134,7 +134,7 @@ validation.
 
 ### run_command
 
-Requires the **shell agent** (>= 1.2.0) on target nodes.
+Requires the **shell agent** (>= 1.2.1) on target nodes.
 
 ```bash
 bolt command run 'hostname -f' --targets node1.example.com,node2.example.com
@@ -146,7 +146,7 @@ process is killed on the target node.
 
 ### run_script
 
-Requires the **shell agent** (>= 1.2.0) on target nodes.
+Requires the **shell agent** (>= 1.2.1) on target nodes.
 
 ```bash
 bolt script run ./check_disk.sh --targets node1.example.com
@@ -205,7 +205,7 @@ task files from an OpenVox/Puppet Server and executes them. This means:
 ### shell (separate install)
 
 The [shell agent](https://github.com/choria-plugins/shell-agent) is a
-separate Choria plugin. Version 1.2.0 or later is required. It must be
+separate Choria plugin. Version 1.2.1 or later is required. It must be
 installed on target nodes.
 
 With the shell agent:
@@ -220,7 +220,7 @@ and loaded automatically. No client-side setup is needed.
 
 On first contact with a target, the transport automatically discovers which
 agents are installed and what OS the target is running. This happens
-transparently. Agents below the required minimum version (e.g., shell < 1.2.0)
+transparently. Agents below the required minimum version (e.g., shell < 1.2.1)
 are excluded and treated as unavailable.
 
 If a target is missing the required agent, it gets a clear error result with
@@ -235,7 +235,7 @@ Install via Puppet by referencing the GitHub repository in your Puppetfile:
 ```ruby
 mod 'mcollective_agent_shell',
   git: 'https://github.com/choria-plugins/shell-agent',
-  ref: 'v1.2.0'
+  ref: 'v1.2.1'
 ```
 
 Deploy with r10k or Code Manager, then apply via Hiera:
@@ -347,7 +347,7 @@ local modulepath matters.
 
 2. **Shell agent not installed by default.** Without it, only `run_task`
    (via bolt_tasks + OpenVox/Puppet Server) works. All other operations fail with a
-   clear error message. Version 1.2.0 or later is required.
+   clear error message. Version 1.2.1 or later is required.
 
 3. **bolt_tasks requires an OpenVox/Puppet Server.** The bolt_tasks agent downloads
    task files from the OpenVox/Puppet Server. Tasks not served by the OpenVox/Puppet Server

lib/bolt/transport/choria.rb

@@ -24,7 +24,7 @@ module Transport
     #     them via task_wrapper. All other operations fail with an actionable
     #     error directing the user to install the shell agent.
     #
-    #   shell agent installed (>= 1.2.0): run_command, run_script, and
+    #   shell agent installed (>= 1.2.1): run_command, run_script, and
     #     run_task work. run_task uses the bolt_tasks agent by default.
     #     To run local tasks via the shell agent, set task-agent to 'shell'
     #     in project config or specify --choria-task-agent shell.

lib/bolt/transport/choria/agent_discovery.rb

@@ -3,7 +3,7 @@
 module Bolt
   module Transport
     class Choria
-      SHELL_MIN_VERSION = '1.2.0'
+      SHELL_MIN_VERSION = '1.2.1'
 
       AGENT_MIN_VERSIONS = {
         'shell' => SHELL_MIN_VERSION

lib/bolt/transport/choria/shell.rb

@@ -466,7 +466,7 @@ def shell_list(remaining)
       end
 
       # Fetch stdout/stderr/exitcode from completed targets via the
-      # shell.statuses RPC action. Requires shell agent >= 1.2.0.
+      # shell.statuses RPC action. Requires shell agent >= 1.2.1.
       #
       # @param targets [Hash{Bolt::Target => Hash}] Completed targets mapped to { handle: uuid_string }
       # @return [Hash{Bolt::Target => Hash}] Output hash for each target

lib/mcollective/agent/shell.ddl

@@ -2,7 +2,7 @@ metadata    :name        => "shell",
             :description => "Run commands with the local shell",
             :author      => "Puppet Labs",
             :license     => "Apache-2.0",
-            :version     => "1.2.0",
+            :version     => "1.2.1",
             :url         => "https://github.com/choria-plugins/shell-agent",
             :timeout     => 180
 

spec/lib/bolt_spec/choria.rb

@@ -40,7 +40,7 @@ def make_rpc_result(sender:, statuscode: 0, statusmsg: 'OK', data: {})
     # variables are cleared between `it` blocks.
     #
     # Accepts Bolt::Target objects or host strings, single or as an array.
-    # Agents can be strings (version defaults to '1.2.0') or [name, version]
+    # Agents can be strings (version defaults to '1.2.1') or [name, version]
     # pairs for version-specific scenarios.
     #
     #   stub_agents(target, %w[rpcutil shell])
@@ -51,7 +51,7 @@ def stub_agents(targets, agents, os_family: 'RedHat')
       targets = [targets].flatten
 
       agent_data = agents.map do |agent|
-        name, version = agent.is_a?(Array) ? agent : [agent, '1.2.0']
+        name, version = agent.is_a?(Array) ? agent : [agent, '1.2.1']
         { 'agent' => name, 'name' => name, 'version' => version }
       end
 

spec/unit/transport/choria/agent_discovery_spec.rb

@@ -16,7 +16,7 @@
                              agents: [{ 'agent' => 'rpcutil' }, { 'agent' => 'bolt_tasks' }]
                            })
       r2 = make_rpc_result(sender: target2, data: {
-                             agents: [{ 'agent' => 'rpcutil' }, { 'agent' => 'shell', 'version' => '1.2.0' }]
+                             agents: [{ 'agent' => 'rpcutil' }, { 'agent' => 'shell', 'version' => '1.2.1' }]
                            })
 
       f1 = make_rpc_result(sender: target, data: { value: 'RedHat' })
@@ -80,7 +80,7 @@
     it 'discards responses from unexpected senders' do
       legit = make_rpc_result(sender: target, data: {
                                 agents: [{ 'agent' => 'rpcutil', 'version' => '1.0.0' },
-                                         { 'agent' => 'shell', 'version' => '1.2.0' }]
+                                         { 'agent' => 'shell', 'version' => '1.2.1' }]
                               })
       rogue = make_rpc_result(sender: 'evil.example.com', data: {
                                 agents: [{ 'agent' => 'rpcutil' }, { 'agent' => 'bolt_tasks' }]
@@ -198,7 +198,7 @@
     it 'defaults to POSIX when OS detection fails' do
       result = make_rpc_result(sender: target, data: {
                                  agents: [{ 'agent' => 'rpcutil', 'version' => '1.0.0' },
-                                          { 'agent' => 'shell', 'version' => '1.2.0' }]
+                                          { 'agent' => 'shell', 'version' => '1.2.1' }]
                                })
       allow(mock_rpc_client).to receive(:agent_inventory).and_return([result])
 
@@ -212,7 +212,7 @@
     it 'defaults to POSIX when os.family fact is an empty string' do
       result = make_rpc_result(sender: target, data: {
                                  agents: [{ 'agent' => 'rpcutil', 'version' => '1.0.0' },
-                                          { 'agent' => 'shell', 'version' => '1.2.0' }]
+                                          { 'agent' => 'shell', 'version' => '1.2.1' }]
                                })
 
       fact_result = make_rpc_result(sender: target, data: { value: '' })
@@ -226,7 +226,7 @@
     it 're-raises Bolt::Error from OS detection instead of swallowing it' do
       result = make_rpc_result(sender: target, data: {
                                  agents: [{ 'agent' => 'rpcutil', 'version' => '1.0.0' },
-                                          { 'agent' => 'shell', 'version' => '1.2.0' }]
+                                          { 'agent' => 'shell', 'version' => '1.2.1' }]
                                })
       allow(mock_rpc_client).to receive(:agent_inventory).and_return([result])