rubocop: Fix RSpec/BeNil

Author: bastelfreak

spec/custom_facts/core/execution/posix_spec.rb

@@ -24,13 +24,13 @@
 
       it 'returns nil if the binary is not executable' do
         allow(File).to receive(:executable?).with('/opt/foo').and_return(false)
-        expect(posix_executor.which('/opt/foo')).to be nil
+        expect(posix_executor.which('/opt/foo')).to be_nil
       end
 
       it 'returns nil if the binary is not a file' do
         allow(File).to receive(:executable?).with('/opt/foo').and_return(true)
         allow(FileTest).to receive(:file?).with('/opt/foo').and_return false
-        expect(posix_executor.which('/opt/foo')).to be nil
+        expect(posix_executor.which('/opt/foo')).to be_nil
       end
     end
 
@@ -46,7 +46,7 @@
         allow(File).to receive(:executable?).with('/bin/foo').and_return false
         allow(File).to receive(:executable?).with('/sbin/foo').and_return false
         allow(File).to receive(:executable?).with('/usr/sbin/foo').and_return false
-        expect(posix_executor.which('foo')).to be nil
+        expect(posix_executor.which('foo')).to be_nil
       end
     end
   end
@@ -88,7 +88,7 @@
 
     it 'returns nil if not found' do
       allow(posix_executor).to receive(:which).with('foo').and_return nil
-      expect(posix_executor.expand_command('foo -a | stuff >> /dev/null')).to be nil
+      expect(posix_executor.expand_command('foo -a | stuff >> /dev/null')).to be_nil
     end
   end
 

spec/custom_facts/core/execution/windows_spec.rb

@@ -64,13 +64,13 @@
       it 'returns nil if the binary path is not executable' do
         allow(File).to receive(:executable?).with('C:\Tools\foo.exe').and_return false
 
-        expect(executor.which('C:\Tools\foo.exe')).to be nil
+        expect(executor.which('C:\Tools\foo.exe')).to be_nil
       end
 
       it 'returns nil if the binary is not executable' do
         allow(File).to receive(:executable?).with('\\\\remote\dir\foo.exe').and_return false
 
-        expect(executor.which('\\\\remote\dir\foo.exe')).to be nil
+        expect(executor.which('\\\\remote\dir\foo.exe')).to be_nil
       end
     end
 
@@ -108,7 +108,7 @@
         allow(File).to receive(:executable?).with('C:\Windows\foo.exe').and_return false
         allow(File).to receive(:executable?).with('C:\Windows\System32\Wbem\foo.exe').and_return false
 
-        expect(executor.which('foo.exe')).to be nil
+        expect(executor.which('foo.exe')).to be_nil
       end
     end
   end
@@ -129,7 +129,7 @@
 
     it 'does not expand single quoted binary' do
       allow(executor).to receive(:which).with('\'C:\My').and_return nil
-      expect(executor.expand_command('\'C:\My Tools\foo.exe\' /a /b')).to be nil
+      expect(executor.expand_command('\'C:\My Tools\foo.exe\' /a /b')).to be_nil
     end
 
     it 'quotes expanded binary if found in path with spaces' do
@@ -146,7 +146,7 @@
 
     it 'returns nil if command not found' do
       allow(executor).to receive(:which).with('foo').and_return nil
-      expect(executor.expand_command('foo /a | stuff >> NUL')).to be nil
+      expect(executor.expand_command('foo /a | stuff >> NUL')).to be_nil
     end
   end
 

spec/custom_facts/util/collection_spec.rb

@@ -144,7 +144,7 @@ def load(collection)
 
     it 'returns nil if it cannot find or load the fact' do
       allow(collection.internal_loader).to receive(:load).with(:testing)
-      expect(collection.fact('testing')).to be nil
+      expect(collection.fact('testing')).to be_nil
     end
   end
 

spec/custom_facts/util/fact_spec.rb

@@ -129,7 +129,7 @@
 
   describe 'when returning a value' do
     it 'returns nil if there are no resolutions' do
-      expect(Facter::Util::Fact.new('yay').value).to be nil
+      expect(Facter::Util::Fact.new('yay').value).to be_nil
     end
 
     it 'prefers the highest weight resolution' do

spec/custom_facts/util/parser_spec.rb

@@ -147,7 +147,7 @@ def expects_script_to_return(path, content, result, err = nil)
     def expects_parser_to_return_nil_for_directory(path)
       allow(FileTest).to receive(:file?).with(path).and_return(false)
 
-      expect(LegacyFacter::Util::Parser.parser_for(path).results).to be nil
+      expect(LegacyFacter::Util::Parser.parser_for(path).results).to be_nil
     end
 
     it 'returns a hash of whatever is returned by the executable' do
@@ -310,7 +310,7 @@ def expects_to_parse_powershell(cmd, result)
 
   describe 'nothing parser' do
     it 'uses the nothing parser when there is no other parser' do
-      expect(LegacyFacter::Util::Parser.parser_for('this.is.not.valid').results).to be nil
+      expect(LegacyFacter::Util::Parser.parser_for('this.is.not.valid').results).to be_nil
     end
   end
 

spec/facter/facter_spec.rb

@@ -213,7 +213,7 @@ def stub_no_fact
     it 'returns nil' do
       stub_no_fact
 
-      expect(Facter.value('os.name')).to be nil
+      expect(Facter.value('os.name')).to be_nil
     end
 
     context 'when fact value is false' do
@@ -314,7 +314,7 @@ def stub_no_fact
     it 'searches os core fact and returns nil' do
       allow(Facter::FactManager.instance).to receive(:resolve_core).with(['os.name']).and_return([])
 
-      expect(Facter.core_value('os.name')).to be nil
+      expect(Facter.core_value('os.name')).to be_nil
     end
   end
 
@@ -488,7 +488,7 @@ def stub_no_fact
       it 'logs a debug message' do
         allow(logger).to receive(:debug).with('test')
 
-        expect(Facter.debug(message)).to be(nil)
+        expect(Facter.debug(message)).to be_nil
       end
     end
 

spec/facter/resolvers/aio_agent_version_spec.rb

@@ -45,7 +45,7 @@
       end
 
       it 'resolves to nil' do
-        expect(Facter::Resolvers::AioAgentVersion.resolve(:aio_agent_version)).to be(nil)
+        expect(Facter::Resolvers::AioAgentVersion.resolve(:aio_agent_version)).to be_nil
       end
     end
   end

spec/facter/resolvers/aix/architecture_spec.rb

@@ -32,15 +32,15 @@
       let(:result) { 'test = x86' }
 
       it 'detects architecture as nil' do
-        expect(Facter::Resolvers::Architecture.resolve(:architecture)).to be(nil)
+        expect(Facter::Resolvers::Architecture.resolve(:architecture)).to be_nil
       end
     end
 
     context 'when fails to retrieve fact' do
       let(:result) { nil }
 
       it 'detects architecture as nil' do
-        expect(Facter::Resolvers::Architecture.resolve(:architecture)).to be(nil)
+        expect(Facter::Resolvers::Architecture.resolve(:architecture)).to be_nil
       end
     end
   end

spec/facter/resolvers/aix/filesystems_spec.rb

@@ -31,7 +31,7 @@
     it 'returns nil' do
       result = Facter::Resolvers::Aix::Filesystems.resolve(:file_systems)
 
-      expect(result).to be(nil)
+      expect(result).to be_nil
     end
   end
 end

spec/facter/resolvers/aix/hardware_spec.rb

@@ -27,15 +27,15 @@
       let(:result) { 'test = hardware' }
 
       it 'detects hardware as nil' do
-        expect(Facter::Resolvers::Hardware.resolve(:hardware)).to be(nil)
+        expect(Facter::Resolvers::Hardware.resolve(:hardware)).to be_nil
       end
     end
 
     context 'when fails to retrieve fact' do
       let(:result) { nil }
 
       it 'detects hardware as nil' do
-        expect(Facter::Resolvers::Hardware.resolve(:hardware)).to be(nil)
+        expect(Facter::Resolvers::Hardware.resolve(:hardware)).to be_nil
       end
     end
   end