Skip to content

Commit fa73c6f

Browse files
authored
Merge pull request #36 from bastelfreak/ruby34
Add Ruby 3.4 support
2 parents ad545d5 + bc3eca3 commit fa73c6f

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/unit_tests.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ jobs:
2727
- '3.0'
2828
- '3.2'
2929
- '3.3'
30+
- '3.4'
3031
- 'jruby-9.4.8.0'
3132
runs-on: ubuntu-24.04
3233
steps:

openfact.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ Gem::Specification.new do |spec|
4646
spec.add_development_dependency 'webmock', '~> 3.12'
4747
spec.add_development_dependency 'yard', '~> 0.9'
4848

49+
spec.add_runtime_dependency 'base64', '>= 0.1', '< 0.4'
4950
spec.add_runtime_dependency 'hocon', '~> 1.3'
51+
spec.add_runtime_dependency 'logger', '~> 1.7'
5052
spec.add_runtime_dependency 'thor', ['>= 1.0.1', '< 2']
5153
end

spec/facter/facter_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ def stub_no_fact
598598
context 'when exception and message are hashes' do
599599
let(:message) { { 'a': 1 } }
600600
let(:exception) { { 'b': 2 } }
601-
let(:expected_message) { '{:a=>1}' }
601+
let(:expected_message) { { a: 1 }.to_s }
602602

603603
it_behaves_like 'when exception param is not an exception'
604604
end
@@ -682,7 +682,7 @@ def stub_no_fact
682682
context 'when exception and message are hashes' do
683683
let(:message) { { 'a': 1 } }
684684
let(:exception) { { 'b': 2 } }
685-
let(:expected_message) { '{:a=>1}' }
685+
let(:expected_message) { { a: 1 }.to_s }
686686

687687
it_behaves_like 'when exception param is not an exception'
688688
end
@@ -808,7 +808,7 @@ def stub_no_fact
808808
end
809809

810810
it 'when message is a hash' do
811-
expect(logger).to receive(:warn).with('{:warn=>"message"}')
811+
expect(logger).to receive(:warn).with({ warn: 'message' }.to_s)
812812

813813
Facter.warn({ warn: 'message' })
814814
end

0 commit comments

Comments
 (0)