Skip to content

Commit 56e2231

Browse files
author
Mike van den Hoek
committed
(refactor): hide custom GF fields success views when no success message has been configured
1 parent 8dd2f55 commit 56e2231

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/PrefillGravityForms/GravityForms/Fields/AgeCheckField.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public function get_field_input($form, $value = '', $entry = null)
9797
$bsn = $this->check_bsn_value_from_session();
9898
$dateOfBirth = $value;
9999
$minimumAgeSetting = $this->get_minimum_age_setting();
100-
$maximumAgeSetting = $this->get_maximum_age_setting();
100+
$maximumAgeSetting = $this->get_maximum_age_setting();
101101

102102
if (empty($bsn) || empty($dateOfBirth || (empty($minimumAgeSetting) && empty($maximumAgeSetting)))) {
103103
$message = __('Log in met uw DigiD, zonder BSN-nummer kan de leeftijdscheck niet uitgevoerd worden.', 'prefill-gravity-forms');
@@ -147,9 +147,9 @@ public function get_field_input($form, $value = '', $entry = null)
147147
public function get_field_container($atts, $form)
148148
{
149149
$dateOfBirth = $_POST["input_$this->id"] ?? $this->defaultValue;
150+
$successMessageIsEmpty = empty($this->pgAgeCheckSuccessMessage ?? false);
150151

151-
152-
if ($dateOfBirth && $this->check_age($dateOfBirth)) {
152+
if ($dateOfBirth && $this->check_age($dateOfBirth) && $successMessageIsEmpty) {
153153
$atts = [
154154
'style' => 'display:none',
155155
];

src/PrefillGravityForms/GravityForms/Fields/MunicipalityCheckField.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,9 @@ public function get_field_container($atts, $form)
146146
{
147147
$municipalityCode = $_POST["input_$this->id"] ?? $this->defaultValue;
148148
$municipalityCodeSetting = $this->get_municipality_code_setting();
149+
$successMessageIsEmpty = empty($this->pgMunicipalityCheckSuccessMessage ?? false);
149150

150-
if ($municipalityCodeSetting && $municipalityCode && $this->check_municipality_code($municipalityCodeSetting, $municipalityCode)) {
151+
if ($municipalityCodeSetting && $municipalityCode && $this->check_municipality_code($municipalityCodeSetting, $municipalityCode) && $successMessageIsEmpty) {
151152
$atts = [
152153
'style' => 'display:none',
153154
];

0 commit comments

Comments
 (0)