Skip to content

Commit c0d79df

Browse files
author
Brandon Kirkland
committed
Remove implementation detail comment from foreground mask closing
Simplify the inline comment on the binary_closing replacement to state only the speedup, without making claims about boundary voxel differences.
1 parent 9beb27d commit c0d79df

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,6 @@ jobs:
100100
--durations=20
101101
102102
- name: Upload coverage report
103-
uses: codecov/codecov-action@v6.0.0
103+
uses: codecov/codecov-action@v5.5.2
104104
with:
105105
token: ${{ secrets.CODECOV_TOKEN }}

src/openlifu/seg/skinseg.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ def compute_foreground_mask(
9898
# the point of this step is rather to clean up and smooth out the skin surface of small cavities.
9999
# Uses binary_closing with a 6-connected structuring element iterated
100100
# closing_radius times, which is much faster than the original two-pass
101-
# EDT approach (~15x). The diamond-shaped kernel produces slightly
102-
# different boundary voxels (<0.2%) versus the EDT's Euclidean ball,
103-
# but this does not affect downstream segmentation quality.
101+
# EDT approach (~15x).
104102
closing_r = int(closing_radius)
105103
if closing_r > 0:
106104
pad_width = closing_r + 2

0 commit comments

Comments
 (0)