Clean Up

- removed unused variables
- removed std::format (since GitHub runners don't have gcc-13 yet)

Author: SydMontague

src/Animation.cpp

@@ -234,7 +234,6 @@ MMDAnimation::MMDAnimation(ReadBuffer& buffer, std::size_t boneCount)
         {
             case 0x0000: // keyframe
             {
-                uint16_t timeCode = instruction & 0xFFF;
                 instructions.emplace_back(new KeyframeInstruction(instruction, buffer));
                 break;
             }

src/CLUTMap.cpp

@@ -40,10 +40,6 @@ void CLUTMap::updateBlocks()
 
 void CLUTMap::applyModel(Model& model)
 {
-    auto texturePage = model.getTexturePage();
-    auto clutX       = model.getClutX();
-    auto clutY       = model.getClutY();
-
     for (auto& mesh : model.meshes)
         for (const Face& face : mesh.faces)
         {

src/GLTF.cpp

@@ -5,7 +5,6 @@
 
 #include "GLTF.hpp"
 
-#include <format>
 #include <numbers>
 
 struct Quaternion
@@ -18,12 +17,12 @@ struct Quaternion
     Quaternion() = default;
     Quaternion(FVector angles)
     {
-        double c1 = std::cos((angles.x * std::numbers::pi / 180.0f) * 0.5);
-        double s1 = std::sin((angles.x * std::numbers::pi / 180.0f) * 0.5);
-        double c2 = std::cos((angles.y * std::numbers::pi / 180.0f) * 0.5);
-        double s2 = std::sin((angles.y * std::numbers::pi / 180.0f) * 0.5);
-        double c3 = std::cos((angles.z * std::numbers::pi / 180.0f) * 0.5);
-        double s3 = std::sin((angles.z * std::numbers::pi / 180.0f) * 0.5);
+        float c1 = std::cos((angles.x * std::numbers::pi / 180.0f) * 0.5f);
+        float s1 = std::sin((angles.x * std::numbers::pi / 180.0f) * 0.5f);
+        float c2 = std::cos((angles.y * std::numbers::pi / 180.0f) * 0.5f);
+        float s2 = std::sin((angles.y * std::numbers::pi / 180.0f) * 0.5f);
+        float c3 = std::cos((angles.z * std::numbers::pi / 180.0f) * 0.5f);
+        float s3 = std::sin((angles.z * std::numbers::pi / 180.0f) * 0.5f);
 
         this->w = c1 * c2 * c3 - s1 * s2 * s3;
         this->x = s1 * c2 * c3 + c1 * s2 * s3;
@@ -267,8 +266,13 @@ void GLTFExporter::buildSkeletonScene()
 
     for (auto& mmdNode : mmd.skeleton)
     {
+        // TODO: replace with std::format when GCC13 becomes available on Linux runners
+        // std::format("node-{}", model.nodes.size())
+        std::stringstream nodeName;
+        nodeName << "node-" << model.nodes.size();
+
         tinygltf::Node node;
-        node.name = std::format("node-{}", model.nodes.size());
+        node.name = nodeName.str();
 
         if (mmdNode.object != 255)
         {
@@ -369,12 +373,15 @@ int32_t GLTFExporter::buildMaterial(MaterialMode mode)
 
 void GLTFExporter::buildAnimations()
 {
+    int i = 0; 
     for (auto& raw : mmd.anims->anims)
     {
         Animation data(raw);
         tinygltf::Animation anim;
         int nodeId = 0;
 
+        std::cout << i++ << std::endl;
+
         for (auto a : data.getData())
         {
             std::vector<float> posTime;

src/main.cpp

@@ -3,7 +3,6 @@
 #include "TIM.hpp"
 
 #include <filesystem>
-#include <format>
 #include <fstream>
 #include <iostream>
 
@@ -227,19 +226,29 @@ int main(int count, char* args[])
 
     for (Entry& entry : entries)
     {
-        std::filesystem::path modelPath = dataPath / std::format("CHDAT/MMD{}/{}.MMD", id++ / 30, entry.filename);
+        std::stringstream mmdPath;
+        mmdPath << "CHDAT/MMD" << (id++ / 30) << "/" << entry.filename << ".MMD";
+
+        // TODO: replace with std::format when GCC13 becomes available on Linux runners
+        // std::format("CHDAT/MMD{}/{}.MMD", id++ / 30, entry.filename)
+        std::filesystem::path modelPath = dataPath / mmdPath.str();
 
         if (!std::filesystem::exists(modelPath))
         {
-            std::cout << "File " << modelPath << "does not exist, skipping." << std::endl;
+            std::cout << "File " << modelPath << " does not exist, skipping." << std::endl;
             continue;
         }
 
         Model model(modelPath, entry.skeleton);
         AbstractTIM tim(entry.texture);
         GLTFExporter gltf(model, tim);
 
-        bool success = gltf.save(std::format("output/{}.gltf", entry.filename));
+        // TODO: replace with std::format when GCC13 becomes available on Linux runners
+        // std::format("output/{}.gltf", entry.filename)
+        std::stringstream outputPath;
+        outputPath << "output/" << entry.filename << ".gltf";
+
+        bool success = gltf.save(outputPath.str());
         if (success)
             std::cout << "Written " << entry.filename << std::endl;
         else