resolved most of the tests, up to 86% passing

Author: jehicken

src/common/default_options.cpp

@@ -28,6 +28,7 @@ const nlohmann::json default_options{
          {"Pr", 0.72},        // the Prandtl number
          {"mu",
           -1.0},  // nondimensional viscosity (if negative, use Sutherland's)
+         {"inviscid-mms", false}, // if true, include the inviscid MMS terms
          {"viscous-mms", false}  // if true, include MMS terms for viscous test
      }},
 

src/common/mfem_extensions.cpp

@@ -55,14 +55,17 @@ void RRKImplicitMidpointSolver::Step(Vector &x, double &t, double &dt)
    x_new.Add(0.5 * dt, k);
    // double delta_entropy = f_ode->EntropyChange(dt / 2, x, k);
    double delta_entropy = f_ode->EntropyChange(0.5 * dt, x_new, k);
-   if (out != nullptr)
-   {
-      //*out << "delta_entropy is " << delta_entropy << '\n';   
-      *out << std::setprecision(16);
-      double supply_rate = f_ode->SupplyRate(0.5*dt, x_new, k);
-      *out << ">>>>> supply rate at midpoint is listed below :" << '\n';
-      *out << t << ' ' << supply_rate << '\n';
-   }
+
+   // The following code was used for the flow-control paper;
+   // it should be generalized or deleted eventually
+   // if (out != nullptr)
+   // {
+   //    //*out << "delta_entropy is " << delta_entropy << '\n';   
+   //    *out << std::setprecision(16);
+   //    double supply_rate = f_ode->SupplyRate(0.5*dt, x_new, k);
+   //    *out << ">>>>> supply rate at midpoint is listed below :" << '\n';
+   //    *out << t << ' ' << supply_rate << '\n';
+   // }
    double entropy_old = f_ode->Entropy(x);
    if (out != nullptr)
    {

src/physics/fluidflow/euler_integ_def.hpp

@@ -541,7 +541,7 @@ void FarFieldBC<dim, entvar>::calcFlux(const mfem::Vector &x,
                                        const mfem::Vector &q,
                                        mfem::Vector &flux_vec)
 {
-   calcFarFieldFlux2<double, dim, entvar>(dir.GetData(),
+   calcFarFieldFlux<double, dim, entvar>(dir.GetData(),
                                          qfs.GetData(),
                                          q.GetData(),
                                          work_vec.GetData(),

src/physics/fluidflow/flow_residual.cpp

@@ -154,11 +154,13 @@ void FlowResidual<dim, entvar>::addFlowDomainIntegrators(
              " state!\n");
       }
       res.addDomainIntegrator(new EulerIntegrator<dim>(stack));
-      if (flow["inviscid-mms"])
-      {  
-         res.addDomainIntegrator(new InviscidMMSIntegrator(-1.0,dim));
-      }
    }
+
+   if (flow.value("inviscid-mms", false))
+   {  
+      res.addDomainIntegrator(new InviscidMMSIntegrator(-1.0,dim));
+   }
+   
    // add the LPS stabilization, if necessary
    auto lps_coeff = space_dis["lps-coeff"];
    if (lps_coeff > 0.0)
@@ -171,7 +173,7 @@ void FlowResidual<dim, entvar>::addFlowDomainIntegrators(
    {  
       res.addDomainIntegrator(
           new ESViscousIntegrator<dim>(stack, re_fs, pr_fs, mu));
-      if (flow["viscous-mms"])
+      if (flow.value("viscous-mms", false))
       {
          if (dim != 2)
          {  

src/physics/miso_nonlinearform.cpp

@@ -106,6 +106,7 @@ mfem::Operator &getJacobian(MISONonlinearForm &form,
                             const MISOInputs &inputs,
                             const std::string &wrt)
 {
+   // TODO: the warning below should be active at some level of verbosity
    std::cout << "Re-assembling Jacobian!\n";
 
    mfem::Vector state;

test/README.md

@@ -1,3 +1,9 @@
 # Contents of the Test directory
 
-As you would expect, this is where the unit tests will go
+The tests are built (from the `build` folder) by running `make tests`.  See the **Tests** Section of the main README file for more details.
+
+If you only want to recompile and then run a single test, you can do so as follows:
+```
+make <test name without .cpp>.bin
+mpirun -n 1 ./<test name without .cpp>.bin
+```

test/regression/test_steady_vortex.cpp

@@ -15,7 +15,7 @@ auto options = R"(
 {
    "print-options": false,
    "flow-param": {
-      "miso": 1.0,
+      "mach": 1.0,
       "aoa": 0.0
    },
    "space-dis": {