Skip to content

Commit 16a4dd3

Browse files
OreoYangclaude
andcommitted
fix: correct style issues and bugs in ivy_guc.c
- Fix typo: "shown as blow" -> "shown below" - Fix duplicate period in error hint message - Fix null terminator placement in nls_case_conversion function - Remove extra blank lines for consistent code style - Add missing period in Apache License header Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 744f756 commit 16a4dd3

1 file changed

Lines changed: 14 additions & 17 deletions

File tree

src/backend/utils/misc/ivy_guc.c

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
6-
* You may obtain a copy of the License at
6+
* You may obtain a copy of the License at.
77
*
88
* http://www.apache.org/licenses/LICENSE-2.0
99
*
@@ -34,9 +34,9 @@ int identifier_case_switch = INTERCHANGE;
3434
bool identifier_case_from_pg_dump = false;
3535
bool enable_case_switch = true;
3636

37-
static char *nls_territory = "AMERICA";
38-
static char *nls_currency = "$";
39-
static char *nls_iso_currency = "AMERICA";
37+
static char *nls_territory = "AMERICA";
38+
static char *nls_currency = "$";
39+
static char *nls_iso_currency = "AMERICA";
4040

4141
bool enable_emptystring_to_NULL = false;
4242

@@ -56,7 +56,7 @@ int rowid_seq_cache = 20;
5656

5757
#ifdef IVY_GUC_VAR_STRUCT
5858

59-
/* The comments shown as blow define the
59+
/* The comments shown as below define the
6060
* value range of guc parameters "database_mode"
6161
* and "compatible_db".
6262
*/
@@ -72,10 +72,8 @@ static const struct config_enum_entry db_parser_options[] = {
7272
{"pg", PG_PARSER, false},
7373
{"oracle", ORA_PARSER, false},
7474
{NULL, 0, false}
75-
7675
};
7776

78-
7977
static const struct config_enum_entry case_conversion_mode[] = {
8078
{"normal", NORMAL, false},
8179
{"interchange", INTERCHANGE, false},
@@ -184,15 +182,14 @@ static struct config_bool Ivy_ConfigureNamesBool[] =
184182
},
185183

186184
/*
187-
* ivorysql.default_with_rowids
185+
* ivorysql.default_with_rowids
188186
*
189-
* When enabled, all newly created tables will automatically include
190-
* an Oracle-compatible ROWID pseudo-column. This provides compatibility
191-
* with Oracle applications that rely on ROWID for row identification.
187+
* When enabled, all newly created tables will automatically include an
188+
* Oracle-compatible ROWID pseudo-column. This provides compatibility with
189+
* Oracle applications that rely on ROWID for row identification.
192190
*
193-
* Default: off
194-
* Context: USERSET (can be changed by any user)
195-
*/
191+
* Default: off Context: USERSET (can be changed by any user)
192+
*/
196193
{
197194
{"ivorysql.default_with_rowids", PGC_USERSET, DEVELOPER_OPTIONS,
198195
gettext_noop("Automatically add rowid column when creating new tables."),
@@ -477,7 +474,7 @@ check_compatible_mode(int *newval, void **extra, GucSource source)
477474
ereport(ERROR,
478475
(errcode(ERRCODE_SYSTEM_ERROR),
479476
errmsg("IVORYSQL_ORA library not found!"),
480-
errhint("You must load IVORYSQL_ORA to use oracle parser..")));
477+
errhint("You must load IVORYSQL_ORA to use oracle parser.")));
481478
}
482479
}
483480
return true;
@@ -536,14 +533,14 @@ nls_case_conversion(char **param, char type)
536533
for (p = *param; p < *param + strlen(*param); ++p)
537534
if (97 <= *p && *p <= 122)
538535
*p -= 32;
539-
*p = '\0';
536+
*(*param + strlen(*param)) = '\0';
540537
}
541538
else if (type == 'l')
542539
{
543540
for (p = *param; p < *param + strlen(*param); ++p)
544541
if (65 <= *p && *p <= 90)
545542
*p += 32;
546-
*p = '\0';
543+
*(*param + strlen(*param)) = '\0';
547544
}
548545
else if (type == 'b')
549546
{

0 commit comments

Comments
 (0)