FCLOSE should raise on invalid handle, not warn and return

yasir-hussain-shah · yasir-hussain-shah · commit eb55e5a67020 · 2026-03-02T20:37:20.000+05:00
diff --git a/contrib/ivorysql_ora/src/builtin_packages/utl_file/utl_file.c b/contrib/ivorysql_ora/src/builtin_packages/utl_file/utl_file.c
@@ -438,8 +438,7 @@ ora_utl_file_fclose(PG_FUNCTION_ARGS)
 
 	if(fd == NULL)
 	{
-		INVALID_FILEHANDLE_WARNING();
-		PG_RETURN_NULL();
+		INVALID_FILEHANDLE_EXCEPTION();
 	}
 
 	if (fclose(fd) == 0)

Original file line number	Diff line number	Diff line change
`@@ -438,8 +438,7 @@ ora_utl_file_fclose(PG_FUNCTION_ARGS)`
`438`	`438`
`439`	`439`	`if(fd == NULL)`
`440`	`440`	`{`
`441`		`- INVALID_FILEHANDLE_WARNING();`
`442`		`- PG_RETURN_NULL();`
	`441`	`+ INVALID_FILEHANDLE_EXCEPTION();`
`443`	`442`	`}`
`444`	`443`
`445`	`444`	`if (fclose(fd) == 0)`