Fixed clang warnings (#623)

Author: adriengivry

Sources/OvAudio/premake5.lua

@@ -4,6 +4,7 @@ project "OvAudio"
 	cppdialect "C++20"
 	targetdir (outputdir .. "%{cfg.buildcfg}/%{prj.name}")
 	objdir (objoutdir .. "%{cfg.buildcfg}/%{prj.name}")
+	fatalwarnings { "All" }
 
 	files {
 		"**.h",

Sources/OvCore/include/OvCore/Rendering/PostProcess/AEffect.h

@@ -32,13 +32,18 @@ namespace OvCore::Rendering::PostProcess
 		*/
 		AEffect(OvRendering::Core::CompositeRenderer& p_renderer);
 
+		/**
+		* Virtual destructor
+		*/
+		virtual ~AEffect() = default;
+
 		/**
 		* Returns true if the effect is applicable with the given settings.
 		* If the effect is not applicable, it will be skipped by the post processing render pass
 		* @param p_settings
 		*/
 		virtual bool IsApplicable(const EffectSettings& p_settings) const;
-
+		
 		/**
 		* Draw the effect
 		* @note: make sure the effect is applicable before calling this method

Sources/OvCore/include/OvCore/Rendering/ReflectionRenderFeature.h

@@ -71,6 +71,6 @@ namespace OvCore::Rendering
 
 	protected:
 		virtual void OnBeginFrame(const OvRendering::Data::FrameDescriptor& p_frameDescriptor) override;
-		virtual void OnBeforeDraw(OvRendering::Data::PipelineState& p_pso, const OvRendering::Entities::Drawable& p_drawable);
+		virtual void OnBeforeDraw(OvRendering::Data::PipelineState& p_pso, const OvRendering::Entities::Drawable& p_drawable) override;
 	};
 }

Sources/OvCore/premake5.lua

@@ -4,6 +4,7 @@ project "OvCore"
 	cppdialect "C++20"
 	targetdir (outputdir .. "%{cfg.buildcfg}/%{prj.name}")
 	objdir (objoutdir .. "%{cfg.buildcfg}/%{prj.name}")
+	fatalwarnings { "All" }
 
 	-- If MSVC, set big obj flag
 	filter { "toolset:msc" }

Sources/OvCore/src/OvCore/ECS/Components/CAudioSource.cpp

@@ -207,7 +207,7 @@ void OvCore::ECS::Components::CAudioSource::OnInspector(OvUI::Internal::WidgetCo
 		{
 			float graphY = graphX < m_audioSource.GetAttenuationThreshold() ? 1.0f : 1.0f / (1.0f + 1.0f * (graphX - m_audioSource.GetAttenuationThreshold()));
 
-			if (abs(graphX - distanceToListener) <= 0.25f)
+			if (std::abs(graphX - distanceToListener) <= 0.25f)
 			{
 				graph.forceHover = static_cast<int>(graphX * 4.0f);
 				graph.overlay = std::to_string(static_cast<int>(graphY * 100.0f)) + "%";

Sources/OvCore/src/OvCore/Rendering/PostProcessRenderPass.cpp

@@ -68,18 +68,23 @@ void OvCore::Rendering::PostProcessRenderPass::Draw(OvRendering::Data::PipelineS
 
 		for (auto& effect : m_effects)
 		{
-			const auto& settings = stack->Get(typeid(*effect));
-
-			if (effect && effect->IsApplicable(settings))
+			if (effect)
 			{
-				effect->Draw(
-					p_pso,
-					m_pingPongBuffers[0],
-					m_pingPongBuffers[1],
-					settings
-				);
-
-				++m_pingPongBuffers;
+				auto& effectRef = *effect;
+				const auto& effectType = typeid(effectRef);
+				const auto& settings = stack->Get(effectType);
+
+				if (effect->IsApplicable(settings))
+				{
+					effect->Draw(
+						p_pso,
+						m_pingPongBuffers[0],
+						m_pingPongBuffers[1],
+						settings
+					);
+
+					++m_pingPongBuffers;
+				}
 			}
 		}
 

Sources/OvCore/src/OvCore/Rendering/SceneRenderer.cpp

@@ -297,6 +297,7 @@ SceneRenderer::SceneDrawablesDescriptor OvCore::Rendering::SceneRenderer::ParseS
 				case MESH_BOUNDS: return mesh->GetBoundingSphere();
 				case DEPRECATED_MODEL_BOUNDS: return model->GetBoundingSphere();
 				case CUSTOM_BOUNDS: return modelRenderer->GetCustomBoundingSphere();
+				default: return std::nullopt;
 				}
 				return std::nullopt;
 			}();

Sources/OvCore/src/OvCore/ResourceManagement/MaterialManager.cpp

@@ -13,7 +13,7 @@ OvCore::Resources::Material * OvCore::ResourceManagement::MaterialManager::Creat
 	Resources::Material* material = OvCore::Resources::Loaders::MaterialLoader::Create(realPath);
 	if (material)
 	{
-		*reinterpret_cast<std::string*>(reinterpret_cast<char*>(material) + offsetof(Resources::Material, path)) = p_path.string(); // Force the resource path to fit the given path
+		const_cast<std::string&>(material->path) = p_path.string(); // Force the resource path to fit the given path
 	}
 
 	return material;

Sources/OvCore/src/OvCore/ResourceManagement/ModelManager.cpp

@@ -46,15 +46,17 @@ OvRendering::Resources::Parsers::EModelParserFlags GetAssetMetadata(const std::s
 	if (metaFile.GetOrDefault("DROP_NORMALS",				false))	flags |= OvRendering::Resources::Parsers::EModelParserFlags::DROP_NORMALS;
 	if (metaFile.GetOrDefault("GEN_BOUNDING_BOXES",			false))	flags |= OvRendering::Resources::Parsers::EModelParserFlags::GEN_BOUNDING_BOXES;
 
-	return { flags };
+	return flags;
 }
 
 OvRendering::Resources::Model* OvCore::ResourceManagement::ModelManager::CreateResource(const std::filesystem::path& p_path)
 {
 	std::string realPath = GetRealPath(p_path).string();
 	auto model = OvRendering::Resources::Loaders::ModelLoader::Create(realPath, GetAssetMetadata(realPath));
 	if (model)
-		*reinterpret_cast<std::string*>(reinterpret_cast<char*>(model) + offsetof(OvRendering::Resources::Model, path)) = p_path.string(); // Force the resource path to fit the given path
+	{
+		const_cast<std::string&>(model->path) = p_path.string(); // Force the resource path to fit the given path
+	}
 
 	return model;
 }

Sources/OvCore/src/OvCore/ResourceManagement/ShaderManager.cpp

@@ -12,7 +12,9 @@ OvRendering::Resources::Shader* OvCore::ResourceManagement::ShaderManager::Creat
 	auto pathParserCallback = [this](const std::string& s) { return GetRealPath(std::filesystem::path{s}).string(); };
 	OvRendering::Resources::Shader* shader = OvRendering::Resources::Loaders::ShaderLoader::Create(realPath, pathParserCallback);
 	if (shader)
-		*reinterpret_cast<std::string*>(reinterpret_cast<char*>(shader) + offsetof(OvRendering::Resources::Shader, path)) = p_path.string(); // Force the resource path to fit the given path
+	{
+		const_cast<std::string&>(shader->path) = p_path.string(); // Force the resource path to fit the given path
+	}
 
 	return shader;
 }