Fixed resample issue when input had collinear points

Author: Nebukam

Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Private/Paths/PCGExExtrudeTensors.cpp

@@ -118,7 +118,7 @@ namespace PCGExExtrudeTensors
 		PointDataFacade->Source->GetOutKeys(true);
 	}
 
-	bool FExtrusion::Extrude(const PCGExTensor::FTensorSample& Sample, const FPCGPoint& InPoint)
+	bool FExtrusion::Extrude(const PCGExTensor::FTensorSample& Sample, FPCGPoint& InPoint)
 	{
 		// return whether we can keep extruding or not
 
@@ -131,13 +131,12 @@ namespace PCGExExtrudeTensors
 		if (DistToLastSum < Settings->FuseDistance) { return true; }
 		DistToLastSum = 0;
 
-		FVector TargetPosition = Metrics.Last;
 
-		if (Length >= MaxLength)
+		if (Length > MaxLength)
 		{
 			// Adjust position to match max length
 			const FVector LastValidPos = ExtrudedPoints.Last().Transform.GetLocation();
-			TargetPosition = LastValidPos + ((TargetPosition - LastValidPos).GetSafeNormal() * (Length - MaxLength));
+			InPoint.Transform.SetLocation(LastValidPos + ((Metrics.Last - LastValidPos).GetSafeNormal() * (Length - MaxLength)));
 		}
 
 		Insert(InPoint);

Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Private/Paths/PCGExResamplePath.cpp

@@ -149,7 +149,7 @@ namespace PCGExResamplePath
 						EndIndex = 0;
 					}
 
-					NextPosition = InPoints[EndIndex].Transform.GetLocation();
+					NextPosition = InPoints[EndIndex].Transform.GetLocation();					
 					DistToNext = FVector::Dist(PrevPosition, NextPosition);
 
 					if (Remainder <= DistToNext) { PrevPosition = PrevPosition + (Path->DirToPrevPoint(EndIndex) * -Remainder); }
@@ -192,7 +192,8 @@ namespace PCGExResamplePath
 
 		//if (SourcesRange == 1)
 		//{
-		const double Weight = FVector::DistSquared(Path->GetPos(Sample.Start), Sample.Location) / FVector::DistSquared(Path->GetPos(Sample.Start), Path->GetPos(Sample.End));
+		// TODO : Implement proper blending. Division by zero here when there are collocated points
+		const double Weight = 0.5; //FVector::DistSquared(Path->GetPos(Sample.Start), Sample.Location) / FVector::DistSquared(Path->GetPos(Sample.Start), Path->GetPos(Sample.End));
 		MetadataBlender->PrepareForBlending(Index);
 		MetadataBlender->Blend(Index, Sample.Start, Index, Weight);
 		MetadataBlender->Blend(Index, Sample.End, Index, 1 - Weight);

Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExExtrudeTensors.h

@@ -278,7 +278,7 @@ namespace PCGExExtrudeTensors
 
 	protected:
 		bool OnAdvanced(const bool bStop);
-		bool Extrude(const PCGExTensor::FTensorSample& Sample, const FPCGPoint& InPoint);
+		bool Extrude(const PCGExTensor::FTensorSample& Sample, FPCGPoint& InPoint);
 		void StartNewExtrusion();
 		void Insert(const FPCGPoint& InPoint) const;
 	};