fix(ui): unmount settings screen after close

Author: pascalandr

packages/ui/src/App.tsx

@@ -95,7 +95,6 @@ const App: Component = () => {
   const [escapeInDebounce, setEscapeInDebounce] = createSignal(false)
   const [instanceTabBarHeight, setInstanceTabBarHeight] = createSignal(0)
   const [cachedInstanceIds, setCachedInstanceIds] = createSignal<string[]>([])
-  const [settingsScreenLoaded, setSettingsScreenLoaded] = createSignal(false)
 
   const phoneQuery = useMediaQuery("(max-width: 767px)")
   const isPhoneLayout = createMemo(() => phoneQuery())
@@ -230,12 +229,6 @@ const App: Component = () => {
     requestAnimationFrame(() => updateInstanceTabBarHeight())
   })
 
-  createEffect(() => {
-    if (settingsOpen()) {
-      setSettingsScreenLoaded(true)
-    }
-  })
-
   createEffect(() => {
     const currentInstances = instances()
     const activeId = activeInstanceId()
@@ -611,7 +604,7 @@ const App: Component = () => {
           </div>
         </Show>
 
-        <Show when={settingsScreenLoaded()}>
+        <Show when={settingsOpen()}>
           <Suspense fallback={null}>
             <LazySettingsScreen />
           </Suspense>