Skip to content

Commit f03a84a

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Sirus Metor and Maven Memory game damage values (#9372)
When I implemented the new enemy Phys to ele damage multiplier, I forgot to implement it for the 2 boss skills that also use it Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent b96dbc2 commit f03a84a

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

src/Modules/CalcDefence.lua

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1702,10 +1702,15 @@ function calcs.buildDefenceEstimations(env, actor)
17021702
conversionTotal = conversions["total"] + conversions["totalSkill"]
17031703
-- Calculate the amount converted/gained as
17041704
for _, damageTypeTo in ipairs(dmgTypeList) do
1705-
local gainAsPercent = (enemyDB:Sum("BASE", enemyCfg, (damageType.."DamageGainAs"..damageTypeTo)) + conversions[damageTypeTo.."skill"] + conversions[damageTypeTo]) / 100
1706-
if gainAsPercent > 0 then
1705+
local gainAsPercent = enemyDB:Sum("BASE", enemyCfg, (damageType.."DamageGainAs"..damageTypeTo)) / 100
1706+
local conversionPercent = (conversions[damageTypeTo.."skill"] + conversions[damageTypeTo]) / 100
1707+
if conversionPercent > 0 and damageType == "Physical" and damageTypeTo ~= "Chaos" then
1708+
local physBonus = 1 + data.monsterPhysConversionMultiTable[env.enemyLevel] / 100
1709+
conversionPercent = conversionPercent * physBonus
1710+
end
1711+
if gainAsPercent > 0 or conversionPercent > 0 then
17071712
enemyDamageConversion[damageTypeTo] = enemyDamageConversion[damageTypeTo] or { }
1708-
enemyDamageConversion[damageTypeTo][damageType] = enemyDamage * gainAsPercent
1713+
enemyDamageConversion[damageTypeTo][damageType] = enemyDamage * gainAsPercent + enemyDamage * conversionPercent
17091714
end
17101715
end
17111716
end

0 commit comments

Comments
 (0)