refactor: createTransaction -> upsertTransaction

Author: chedieck

services/chronikService.ts

@@ -9,7 +9,7 @@ import {
   createManyTransactions,
   deleteTransactions,
   fetchUnconfirmedTransactions,
-  createTransaction,
+  upsertTransaction,
   getSimplifiedTransactions,
   getSimplifiedTrasaction,
   connectAllTransactionsToPrices
@@ -417,7 +417,7 @@ export class ChronikBlockchainClient {
         const addressesWithTransactions = await this.getAddressesForTransaction(transaction)
         const inputAddresses = this.getSortedInputAddresses(transaction)
         for (const addressWithTransaction of addressesWithTransactions) {
-          const { created, tx } = await createTransaction(addressWithTransaction.transaction)
+          const { created, tx } = await upsertTransaction(addressWithTransaction.transaction)
           if (tx !== undefined) {
             const broadcastTxData = this.broadcastIncomingTx(addressWithTransaction.address.address, tx, inputAddresses)
             if (created) { // only execute trigger for newly added txs
@@ -470,7 +470,7 @@ export class ChronikBlockchainClient {
       const inputAddresses = this.getSortedInputAddresses(transaction)
 
       for (const addressWithTransaction of addressesWithTransactions) {
-        const { created, tx } = await createTransaction(addressWithTransaction.transaction)
+        const { created, tx } = await upsertTransaction(addressWithTransaction.transaction)
         if (tx !== undefined) {
           const broadcastTxData = this.broadcastIncomingTx(addressWithTransaction.address.address, tx, inputAddresses)
           if (created) { // only execute trigger for newly added txs

services/transactionService.ts

@@ -295,7 +295,7 @@ interface CreateTransactionResult {
   created: boolean
 }
 
-export async function createTransaction (
+export async function upsertTransaction (
   transactionData: Prisma.TransactionUncheckedCreateInput
 ): Promise<CreateTransactionResult> {
   if (transactionData.amount === new Prisma.Decimal(0)) { // out transactions

tests/unittests/transactionService.test.ts

@@ -71,7 +71,7 @@ describe('Create services', () => {
       ...mockedTransaction,
       addressId: mockedBCHAddress.id
     }
-    const result = await transactionService.createTransaction(
+    const result = await transactionService.upsertTransaction(
       argsTransaction
     )
     expect(result).toEqual({