Merge pull request #836 from PayButton/feat/better-error-message-for-missing-prices

feat: better error message for missing prices

Author: Klakurka

constants/index.ts

@@ -50,7 +50,7 @@ export const RESPONSE_MESSAGES = {
   NETWORK_SLUG_NOT_PROVIDED_400: { statusCode: 400, message: "'networkSlug' not provided." },
   QUOTE_SLUG_NOT_PROVIDED_400: { statusCode: 400, message: "'quoteSlug' not provided." },
   NO_CURRENT_PRICES_FOUND_404: { statusCode: 404, message: 'Current prices not found.' },
-  NO_PRICES_FOUND_404: { statusCode: 404, message: 'Prices not found.' },
+  NO_PRICES_FOUND_404: (networkId: number, timestamp: number) => { return { statusCode: 404, message: `Prices not found for ${NETWORK_TICKERS_FROM_ID[networkId]} at timestamp ${timestamp}.` } },
   INVALID_QUOTE_SLUG_400: { statusCode: 400, message: 'Invalid quote slug.' },
   INVALID_TICKER_400: { statusCode: 400, message: 'Invalid ticker.' },
   MISSING_BLOCKCHAIN_CLIENT_400: { statusCode: 400, message: 'There is no blockchain client chosen for this network.' },

services/priceService.ts

@@ -242,7 +242,7 @@ export async function fetchPricesForNetworkAndTimestamp (networkId: number, time
     if (attempt < PRICE_API_MAX_RETRIES) {
       return await fetchPricesForNetworkAndTimestamp(networkId, timestamp, prisma, attempt + 1)
     }
-    throw new Error(RESPONSE_MESSAGES.NO_PRICES_FOUND_404.message)
+    throw new Error(RESPONSE_MESSAGES.NO_PRICES_FOUND_404(networkId, timestamp).message)
   }
   return {
     cad: cadPrice,