Skip to content

Commit bdf8091

Browse files
committed
test: fix throwing error
1 parent f5f0afb commit bdf8091

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

services/addressService.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,18 @@ export async function fetchAddressBySubstring (substring: string): Promise<Addre
124124
return results[0]
125125
}
126126

127-
export async function addressExistsBySubstring (substring: string): Promise<boolean> {
127+
export async function addressExists (addressString: string, raise = false): Promise<boolean> {
128128
try {
129-
await fetchAddressBySubstring(substring)
129+
await prisma.address.findUniqueOrThrow({
130+
where: {
131+
address: addressString
132+
}
133+
})
130134
} catch (err: any) {
131-
switch (err.message) {
132-
case RESPONSE_MESSAGES.NO_ADDRESS_FOUND_404.message:
133-
return false
134-
default:
135-
throw new Error(err)
135+
if (raise) {
136+
throw new Error(RESPONSE_MESSAGES.NO_ADDRESS_FOUND_404.message)
136137
}
138+
return false
137139
}
138140
return true
139141
}

services/transactionService.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import prisma from 'prisma/clientInstance'
22
import { Address, Prisma, Transaction } from '@prisma/client'
33
import { syncTransactionsForAddress, subscribeAddresses } from 'services/blockchainService'
4-
import { fetchAddressBySubstring, fetchAddressById, fetchAddressesByPaybuttonId } from 'services/addressService'
4+
import { fetchAddressBySubstring, fetchAddressById, fetchAddressesByPaybuttonId, addressExists } from 'services/addressService'
55
import { QuoteValues, fetchPricesForNetworkAndTimestamp } from 'services/priceService'
66
import { RESPONSE_MESSAGES, USD_QUOTE_ID, CAD_QUOTE_ID, N_OF_QUOTES, KeyValueT, UPSERT_TRANSACTION_PRICES_ON_DB_TIMEOUT, SupportedQuotesType, NETWORK_IDS } from 'constants/index'
77
import { productionAddresses } from 'prisma/seeds/addresses'
@@ -159,10 +159,12 @@ export async function fetchPaginatedAddressTransactions (addressString: string,
159159
}
160160
}
161161

162+
const parsedAddress = parseAddress(addressString)
163+
await addressExists(parsedAddress, true)
162164
const txs = await prisma.transaction.findMany({
163165
where: {
164166
address: {
165-
address: parseAddress(addressString)
167+
address: parsedAddress
166168
}
167169
},
168170
include: includeAddressAndPrices,

0 commit comments

Comments
 (0)