wage type script controller: fixed custom results storage of field periods (source is payroll cluster-set for period results)

Jani Giannoudis · Jani Giannoudis · commit afc0a1eb570b · 2026-02-18T18:31:47.000+01:00
case value provider calculation: ensure period end is not on midnight
added stored procedure to updated the database statstics (tipping point)
updated version to 0.9.0-beta.17
diff --git a/Api/Api.Core/AuthenticationConfiguration.cs b/Api/Api.Core/AuthenticationConfiguration.cs
@@ -9,6 +9,7 @@ public class AuthenticationConfiguration
     public AuthenticationMode Mode { get; set; } = AuthenticationMode.None;
 
     /// <summary>Api key — only used when Mode is ApiKey</summary>
+    // ReSharper disable once UnusedAutoPropertyAccessor.Global
     public string ApiKey { get; set; }
 
     /// <summary>OAuth 2.0 / JWT Bearer settings — only used when Mode is OAuth</summary>
diff --git a/Api/Api.Core/OAuthConfiguration.cs b/Api/Api.Core/OAuthConfiguration.cs
@@ -12,6 +12,7 @@ public class OAuthConfiguration
     public string Audience { get; set; }
 
     /// <summary>Require HTTPS metadata (default: true)</summary>
+    // ReSharper disable once AutoPropertyCanBeMadeGetOnly.Global
     public bool RequireHttpsMetadata { get; set; } = true;
 
     /// <summary>OAuth client secret for Swagger UI (Option B: confidential client)</summary>
diff --git a/Api/Api.Core/PayrunJobWorkerService.cs b/Api/Api.Core/PayrunJobWorkerService.cs
@@ -195,7 +195,10 @@ private async Task MarkJobCompletedAsync(PayrunJobQueueItem queueItem, string re
                 job.ErrorMessage = reason;
 
                 var duration = job.JobEnd.Value - job.JobStart;
-                job.Message = $"Job completed in {duration.ToReadableString()}: {reason}";
+                var durationText = duration < TimeSpan.FromSeconds(1)
+                    ? $"{duration.TotalMicroseconds:2} ms"
+                    : duration.ToReadableString();
+                job.Message = $"Job completed in {durationText}: {reason}";
 
                 await payrunJobRepository.UpdateAsync(dbContext, queueItem.TenantId, job);
 
diff --git a/Api/Api.Map/LookupRangeBracketMap.cs b/Api/Api.Map/LookupRangeBracketMap.cs
@@ -8,6 +8,7 @@ namespace PayrollEngine.Api.Map;
 /// Map a domain object with an api object
 /// </summary>
 [Mapper(EnumMappingStrategy = EnumMappingStrategy.ByName, EnumMappingIgnoreCase = true)]
+// ReSharper disable once UnusedType.Global
 public partial class LookupRangeBracketMap : ApiMapBase<DomainObject.LookupRangeBracket, ApiObject.LookupRangeBracket>
 {
     public override partial ApiObject.LookupRangeBracket ToApi(DomainObject.LookupRangeBracket domainObject);
diff --git a/Api/Api.Model/PayrollEngine.Api.Model.csproj b/Api/Api.Model/PayrollEngine.Api.Model.csproj
@@ -11,7 +11,7 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="PayrollEngine.Core" Version="0.9.0-beta.16" />
+		<PackageReference Include="PayrollEngine.Core" Version="0.9.0-beta.17" />
 	</ItemGroup>
 
 	<ItemGroup>
diff --git a/Backend.Server/PayrollEngine.Backend.Server.csproj b/Backend.Server/PayrollEngine.Backend.Server.csproj
@@ -14,7 +14,7 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="PayrollEngine.Serilog" Version="0.9.0-beta.16" />
+		<PackageReference Include="PayrollEngine.Serilog" Version="0.9.0-beta.17" />
 		<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="10.0.3" />
 		<PackageReference Include="Serilog.AspNetCore" Version="10.0.0" />
 		<PackageReference Include="Serilog.Settings.Configuration" Version="10.0.0" />
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net10.0</TargetFramework>
-		<Version>0.9.0-beta.16</Version>
+		<Version>0.9.0-beta.17</Version>
 		<FileVersion>0.9.0</FileVersion>
 		<InformationalVersion></InformationalVersion>
 		<Authors>Jani Giannoudis</Authors>
diff --git a/Domain/Domain.Model/PayrollEngine.Domain.Model.csproj b/Domain/Domain.Model/PayrollEngine.Domain.Model.csproj
@@ -12,8 +12,8 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="PayrollEngine.Client.Scripting" Version="0.9.0-beta.16" />
-		<PackageReference Include="PayrollEngine.Core" Version="0.9.0-beta.16" />
+		<PackageReference Include="PayrollEngine.Client.Scripting" Version="0.9.0-beta.17" />
+		<PackageReference Include="PayrollEngine.Core" Version="0.9.0-beta.17" />
 	</ItemGroup>
 
 </Project>
diff --git a/Domain/Domain.Scripting/Action/ActionReflector.cs b/Domain/Domain.Scripting/Action/ActionReflector.cs
@@ -254,7 +254,7 @@ private static List<string> GetArrayParameters(SyntaxNode syntaxNode, string arg
             var values = new List<string>();
             foreach (var arrayValueNode in arrayValueNodes)
             {
-                var value = arrayValueNode.GetText().ToString().Trim();
+                var value = arrayValueNode.GetText().ToString()?.Trim();
                 if (!string.IsNullOrWhiteSpace(value))
                 {
                     values.Add(value);
@@ -276,7 +276,7 @@ private static string GetElementText(SyntaxNode syntaxNode)
         {
             return null;
         }
-        var text = syntaxNode.GetText().ToString().Trim('"').Trim();
+        var text = syntaxNode.GetText().ToString()?.Trim('"').Trim();
         return text;
     }
 
diff --git a/Domain/Domain.Scripting/CaseValueProvider.cs b/Domain/Domain.Scripting/CaseValueProvider.cs
@@ -651,17 +651,18 @@ private async Task<IList<CaseFieldValue>> GetCasePeriodValuesAsync(string caseFi
             // moment: build summary
             case CaseFieldTimeType.Moment:
                 GetMomentCasePeriodValuesAsync(caseFieldName, caseField, valuePeriods, values);
-                return values;
+                break;
             case CaseFieldTimeType.Period:
                 // period: use the aggregation type
                 GetAggregationCasePeriodValuesAsync(caseFieldName, caseField, caseValues, valuePeriods, values);
-                return values;
+                break;
             case CaseFieldTimeType.CalendarPeriod:
                 GetCalendarPeriodCasePeriodValuesAsync(caseFieldName, caseField, calculator, valuePeriods, values);
-                return values;
+                break;
             default:
                 throw new ArgumentOutOfRangeException();
         }
+        return values.OrderBy(x => x.Start).ToList();
     }
 
     /// <summary>
diff --git a/Domain/Domain.Scripting/CaseValueProviderCalculation.cs b/Domain/Domain.Scripting/CaseValueProviderCalculation.cs
@@ -223,6 +223,10 @@ private static void SplitCaseValuePeriod(DatePeriod valuePeriod, DatePeriod avai
     private static void AddDatePeriod(List<DatePeriod> list, DateTime start, DateTime end)
     {
         start = start.ToUtc();
+        if (end.IsMidnight())
+        {
+            end = end.PreviousTick();
+        }
         end = end.ToUtc();
 
         // ignore empty periods
diff --git a/Domain/Domain.Scripting/Controller/WageTypeScriptController.cs b/Domain/Domain.Scripting/Controller/WageTypeScriptController.cs
@@ -22,7 +22,10 @@ public class WageTypeScriptController : ScriptControllerBase<WageType>
         LogStopwatch.Start(nameof(WageTypeValueRuntime));
 
         // script runtime
-        var runtime = new WageTypeValueRuntime(settings);
+        var runtime = new WageTypeValueRuntime(settings)
+        {
+            TrackRequestedFields = autoPeriodResults
+        };
 
         // wage type value
         var wageTypeValue = runtime.EvaluateValue(settings.WageType);
diff --git a/Domain/Domain.Scripting/PayrollEngine.Domain.Scripting.csproj b/Domain/Domain.Scripting/PayrollEngine.Domain.Scripting.csproj
@@ -15,7 +15,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="PayrollEngine.Client.Scripting" Version="0.9.0-beta.16" />
+		<PackageReference Include="PayrollEngine.Client.Scripting" Version="0.9.0-beta.17" />
 	</ItemGroup>
 
 </Project>
diff --git a/Domain/Domain.Scripting/Runtime/PayrollRuntimeBase.cs b/Domain/Domain.Scripting/Runtime/PayrollRuntimeBase.cs
@@ -33,11 +33,6 @@ public abstract class PayrollRuntimeBase : RuntimeBase, IPayrollRuntime
     /// </summary>
     private IRegulationLookupProvider RegulationLookupProvider => Settings.RegulationLookupProvider;
 
-    /// <summary>
-    /// Maximum period count
-    /// </summary>
-    public static readonly int MaxPeriodCount = 200;
-
     /// <summary>
     /// Initializes a new instance of the <see cref="PayrollRuntimeBase"/> class
     /// </summary>
@@ -104,6 +99,11 @@ public object GetEmployeeAttribute(string attributeName) =>
     /// <inheritdoc />
     public DateTime EvaluationDate => CaseValueProvider.EvaluationDate;
 
+    /// <summary>
+    /// Track case fields requests
+    /// </summary>
+    public bool TrackRequestedFields { get; init; }
+
     /// <summary>Requested case fields</summary>
     internal HashSet<string> RequestedFields { get; } = [];
 
@@ -367,9 +367,6 @@ private async System.Threading.Tasks.Task<List<CaseValue>> GetTimeCaseValues(ILi
         return values;
     }
 
-    /// <summary>Gets a value indicating whether to track the case field requests</summary>
-    private static bool TrackCaseFieldRequests => false;
-
     /// <inheritdoc />
     public virtual Dictionary<string, List<Tuple<DateTime, DateTime?, DateTime?, object>>> GetCasePeriodValues(DateTime startDate,
         DateTime endDate, params string[] caseFieldNames)
@@ -404,7 +401,7 @@ private async System.Threading.Tasks.Task<List<CaseValue>> GetTimeCaseValues(ILi
         {
             values[periodValue.CaseFieldName].Add(new(periodValue.Created,
                 periodValue.Start, periodValue.End, ValueConvert.ToValue(periodValue.Value, periodValue.ValueType, TenantCulture)));
-            if (TrackCaseFieldRequests)
+            if (TrackRequestedFields)
             {
                 RequestedFields.Add(periodValue.CaseFieldName);
             }
@@ -468,7 +465,7 @@ public virtual string GetLookup(string lookupName, string lookupKey, string cult
             lookupName: lookupName)).Result;
         if (lookup == null)
         {
-            return new();
+            return [];
         }
 
         // query brackets
diff --git a/Persistence/Persistence.SqlServer/Persistence.SqlServer.sln b/Persistence/Persistence.SqlServer/Persistence.SqlServer.sln
@@ -0,0 +1,24 @@
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 17
+VisualStudioVersion = 17.5.2.0
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PayrollEngine.Persistence.SqlServer", "PayrollEngine.Persistence.SqlServer.csproj", "{C44D6AC3-D542-61AE-5D05-00BBCCACAFDE}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{C44D6AC3-D542-61AE-5D05-00BBCCACAFDE}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{C44D6AC3-D542-61AE-5D05-00BBCCACAFDE}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{C44D6AC3-D542-61AE-5D05-00BBCCACAFDE}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{C44D6AC3-D542-61AE-5D05-00BBCCACAFDE}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {FF5068B6-F392-46ED-928F-C9AD74977DED}
+	EndGlobalSection
+EndGlobal
diff --git a/Persistence/Persistence.SqlServer/README.md b/Persistence/Persistence.SqlServer/README.md
@@ -0,0 +1,19 @@
+# Payroll Engine Persistence SQL Server
+👉 This application is part of the [Payroll Engine](https://github.com/Payroll-Engine/PayrollEngine/wiki).
+
+## Tipping Point
+The SQL Server Tipping Point is the performance threshold where the Query Optimizer decides that a Non-Clustered Index Seek with Bookmark Lookups is more expensive than a full Table or Clustered Index Scan. This typically occurs when a query is expected to return between 25% and 33% of the table's data pages, prompting the engine to switch to sequential I/O for better efficiency. It primarily affects non-covering indexes and can be avoided by creating Covering Indexes that include all required columns. 
+
+The Soted Procedure `UpdateStatistics` performs a full scan of all database tables.
+```sql
+DECLARE @sql nvarchar(MAX) = N'';
+SELECT @sql += N'UPDATE STATISTICS ' + QUOTENAME(s.name) + N'.' + QUOTENAME(t.name) + N' WITH FULLSCAN; '
+FROM sys.tables t
+	JOIN sys.schemas s ON t.schema_id = s.schema_id;
+
+EXEC sp_executesql @sql;
+```
+
+Further info:
+- [The Tipping Point Query Answers](https://www.sqlskills.com/blogs/kimberly/the-tipping-point-query-answers/)
+- [How to Think Like the SQL Server Engine: What’s the Tipping Point?](https://www.brentozar.com/archive/2019/10/how-to-think-like-the-sql-server-engine-whats-the-tipping-point/)
diff --git a/Persistence/Persistence.SqlServer/StoredProcedures/UpdateStatistics.sql b/Persistence/Persistence.SqlServer/StoredProcedures/UpdateStatistics.sql
@@ -0,0 +1,41 @@
+-- =============================================
+-- Cleanup database tipping point
+-- see https://www.sqlskills.com/blogs/kimberly/the-tipping-point-query-answers/
+-- see https://www.brentozar.com/archive/2019/10/how-to-think-like-the-sql-server-engine-whats-the-tipping-point/
+-- see 
+
+SET ANSI_NULLS ON
+GO
+
+SET QUOTED_IDENTIFIER ON
+GO
+
+IF EXISTS (
+    SELECT *
+    FROM sysobjects
+    WHERE id = object_id(N'[dbo].[UpdateStatistics]')
+      AND OBJECTPROPERTY(id, N'IsProcedure') = 1
+    )
+BEGIN
+  DROP PROCEDURE dbo.[UpdateStatistics]
+END
+GO
+
+-- =============================================
+-- Update database statistics (tipping point)
+-- see https://www.sqlskills.com/blogs/kimberly/the-tipping-point-query-answers/
+-- see https://www.brentozar.com/archive/2019/10/how-to-think-like-the-sql-server-engine-whats-the-tipping-point/
+-- =============================================
+CREATE PROCEDURE dbo.[UpdateStatistics]
+AS
+BEGIN
+
+DECLARE @sql nvarchar(MAX) = N'';
+SELECT @sql += N'UPDATE STATISTICS ' + QUOTENAME(s.name) + N'.' + QUOTENAME(t.name) + N' WITH FULLSCAN; '
+FROM sys.tables t
+	JOIN sys.schemas s ON t.schema_id = s.schema_id;
+
+EXEC sp_executesql @sql;
+
+END
+GO

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ namespace PayrollEngine.Api.Map;`
`8`	`8`	`/// Map a domain object with an api object`
`9`	`9`	`/// </summary>`
`10`	`10`	`[Mapper(EnumMappingStrategy = EnumMappingStrategy.ByName, EnumMappingIgnoreCase = true)]`
	`11`	`+// ReSharper disable once UnusedType.Global`
`11`	`12`	`public partial class LookupRangeBracketMap : ApiMapBase<DomainObject.LookupRangeBracket, ApiObject.LookupRangeBracket>`
`12`	`13`	`{`
`13`	`14`	`public override partial ApiObject.LookupRangeBracket ToApi(DomainObject.LookupRangeBracket domainObject);`
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ private static List<string> GetArrayParameters(SyntaxNode syntaxNode, string arg`
`254`	`254`	`var values = new List<string>();`
`255`	`255`	`foreach (var arrayValueNode in arrayValueNodes)`
`256`	`256`	`{`
`257`		`- var value = arrayValueNode.GetText().ToString().Trim();`
	`257`	`+ var value = arrayValueNode.GetText().ToString()?.Trim();`
`258`	`258`	`if (!string.IsNullOrWhiteSpace(value))`
`259`	`259`	`{`
`260`	`260`	`values.Add(value);`
`@@ -276,7 +276,7 @@ private static string GetElementText(SyntaxNode syntaxNode)`
`276`	`276`	`{`
`277`	`277`	`return null;`
`278`	`278`	`}`
`279`		`- var text = syntaxNode.GetText().ToString().Trim('"').Trim();`
	`279`	`+ var text = syntaxNode.GetText().ToString()?.Trim('"').Trim();`
`280`	`280`	`return text;`
`281`	`281`	`}`
`282`	`282`