Skip to content

fix(ci): remove [skip ci] from automated commit messages#421

Merged
perasperaactual merged 1 commit into
devfrom
fix/skip-ci-leaking-into-main-merge-commits
May 15, 2026
Merged

fix(ci): remove [skip ci] from automated commit messages#421
perasperaactual merged 1 commit into
devfrom
fix/skip-ci-leaking-into-main-merge-commits

Conversation

@perasperaactual
Copy link
Copy Markdown
Contributor

@perasperaactual perasperaactual commented May 15, 2026

Problem

Automated commits on dev used the GitHub skip-ci flag ([skip-ci]) in their messages to prevent CI reruns. However, GitHub scans the full commit message body, not just the subject line. Standard merge commits to main auto-populate their body with a list of individual PR commits — so any skip-ci flag in a dev commit message leaks into the main merge commit body and suppresses all workflow triggers on that push, before any job-level if conditions can run.

Confirmed: PRs #410 and #419 both show zero workflow runs on main (not even skipped entries) because their merge commit bodies contained skip-ci lines from automated dev commits.

Fix

Remove skip-ci flags from all five automated commit messages across both workflow files. Loop prevention is handled entirely by the existing job-level if conditions, which is the correct mechanism.

Also updates the startsWith guard in release.yml to match the new commit message string, so the loop-prevention logic stays in sync.

Changes

  • prerelease.yml: removed skip-ci flag from chore: bump prerelease versions and chore: enter prerelease mode commits
  • release.yml: removed skip-ci flag from chore: version packages for release and chore: re-enter prerelease mode after back-merge commits; updated job-level if condition to match

Testing

The next dev→main merge after this lands will confirm workflows trigger correctly. workflow_dispatch on release.yml from main can also verify end-to-end.

Automated commits on dev (prerelease version bumps, back-merge re-entry)
used the GitHub skip-ci flag in their messages to suppress CI reruns.
However, GitHub scans the ENTIRE commit message body, not just the subject
line — and standard merge commits to main auto-populate their body with the
list of individual PR commits. This caused the skip flag to appear in the
main merge commit body, suppressing ALL workflow triggers on every
dev-to-main merge.

Remove skip-ci flags from all automated commit messages in prerelease.yml
and release.yml. Loop prevention is handled entirely by the existing
job-level if conditions, which is the correct mechanism. Update the
startsWith guard in release.yml to match the new commit message string.

Root cause confirmed: PRs #410 and #419 both show zero workflow runs on
main because their merge commit bodies contained skip-ci lines from
automated dev commits.
@perasperaactual perasperaactual force-pushed the fix/skip-ci-leaking-into-main-merge-commits branch from 6a6da2c to 8b5f445 Compare May 15, 2026 16:59
@github-actions
Copy link
Copy Markdown
Contributor

✅ Visual Regression Test Results

Status: ✅ All visual tests passed!

All screenshots match the baseline. No visual regressions detected! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

⚡ Performance Benchmark Results

✅ Build Time Benchmarks: PASSED

✅ Bundle Size Benchmarks: PASSED

❌ Runtime Vitals Benchmarks: FAILED

📝 Note: Detailed results are available in the job logs.

🎯 Performance Budgets:

  • Build time: <70s total
  • First-load JS: <100KB gzipped
  • FCP: <1.5s, LCP: <2.5s, TTI: <3s

Updated: 2026-05-15T17:02:25.088Z

@perasperaactual perasperaactual merged commit fa879d1 into dev May 15, 2026
6 of 7 checks passed
@perasperaactual perasperaactual deleted the fix/skip-ci-leaking-into-main-merge-commits branch May 15, 2026 17:02
@github-actions
Copy link
Copy Markdown
Contributor

♿ Accessibility Test Results

Overall Status: ✅ 0/0 tests passed

🦮 WCAG 2.1 AA Compliance

No WCAG test results available

⌨️ Keyboard Navigation

No keyboard navigation test results available


⚠️ No accessibility tests were executed. Check the workflow logs for setup issues.

📊 Detailed Report

Download the full HTML accessibility report from the workflow artifacts for:

  • Detailed WCAG violation descriptions
  • Specific element selectors and fixes
  • Color contrast issues
  • Keyboard navigation flow analysis

🔍 Testing Checklist

Our accessibility tests verify:

  • ✅ WCAG 2.1 Level AA compliance
  • ✅ Color contrast in light and dark modes
  • ✅ Tab key navigation through all interactive elements
  • ✅ Focus indicators are visible
  • ✅ No keyboard traps
  • ✅ Skip links and ARIA landmarks
  • ✅ Screen reader compatibility

Powered by @axe-core/playwright and Playwright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant