Skip to content

Docs/202605018 updates#437

Merged
perasperaactual merged 4 commits into
devfrom
docs/202605018-updates
May 18, 2026
Merged

Docs/202605018 updates#437
perasperaactual merged 4 commits into
devfrom
docs/202605018-updates

Conversation

@perasperaactual
Copy link
Copy Markdown
Contributor

@perasperaactual perasperaactual commented May 18, 2026

Changes in this PR

fix: dark mode toggle always visible on mobile (TopAppBar)

Previously the colorModeToggle was hidden on narrow screens whenever nav menu items were present, due to an overly broad conditional:

// Before — toggle hidden on mobile when menu items exist
{colorModeToggle && (!menuItems || menuItems.length === 0 || !isSmDown) && (
  <ColorModeToggle textColor={headerTextColor} />
)}

Now replaced with three intent-revealing render sites:

Position Condition Layout
Before hamburger isSmDown [🌙] [☰]
After nav links !isSmDown [Link] [Link] [🌙]
No-menu fallback !menuItems || menuItems.length === 0 Always

@github-actions
Copy link
Copy Markdown
Contributor

❌ Visual Regression Test Results

Status: ❌ Visual regression tests failed

Visual differences were detected! Please review:

  1. Download the artifacts from this workflow run
  2. Check the visual-regression-diffs artifact for comparison images
  3. If changes are intentional, update snapshots locally:
    pnpm test:e2e --update-snapshots
    git add packages/e2e/tests/__screenshots__
    git commit -m "Update visual regression baselines"

📸 Baseline screenshots are committed to the repo for reproducible testing.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

⚡ Performance Benchmark Results

✅ Build Time Benchmarks: PASSED

✅ Bundle Size Benchmarks: PASSED

❌ Runtime Vitals Benchmarks: FAILED

📝 Note: Detailed results are available in the job logs.

🎯 Performance Budgets:

  • Build time: <70s total
  • First-load JS: <100KB gzipped
  • FCP: <1.5s, LCP: <2.5s, TTI: <3s

Updated: 2026-05-18T19:50:34.992Z

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

♿ Accessibility Test Results

Overall Status: ✅ 0/0 tests passed

🦮 WCAG 2.1 AA Compliance

No WCAG test results available

⌨️ Keyboard Navigation

No keyboard navigation test results available


⚠️ No accessibility tests were executed. Check the workflow logs for setup issues.

📊 Detailed Report

Download the full HTML accessibility report from the workflow artifacts for:

  • Detailed WCAG violation descriptions
  • Specific element selectors and fixes
  • Color contrast issues
  • Keyboard navigation flow analysis

🔍 Testing Checklist

Our accessibility tests verify:

  • ✅ WCAG 2.1 Level AA compliance
  • ✅ Color contrast in light and dark modes
  • ✅ Tab key navigation through all interactive elements
  • ✅ Focus indicators are visible
  • ✅ No keyboard traps
  • ✅ Skip links and ARIA landmarks
  • ✅ Screen reader compatibility

Powered by @axe-core/playwright and Playwright

Show dark mode toggle on narrow screens alongside the hamburger menu
rather than hiding it. Toggle now renders left of the hamburger on
mobile and right of nav links on desktop. Replaces one compound
conditional with three intent-revealing render sites.

Also updates examples/stackwright-docs/stackwright.yml.
@github-actions
Copy link
Copy Markdown
Contributor

❌ Visual Regression Test Results

Status: ❌ Visual regression tests failed

Visual differences were detected! Please review:

  1. Download the artifacts from this workflow run
  2. Check the visual-regression-diffs artifact for comparison images
  3. If changes are intentional, update snapshots locally:
    pnpm test:e2e --update-snapshots
    git add packages/e2e/tests/__screenshots__
    git commit -m "Update visual regression baselines"

📸 Baseline screenshots are committed to the repo for reproducible testing.

The TopAppBar h1 is now intentionally empty when a wordmark logo is used.
Update smoke and user-journey test selectors from 'h1, h2, h3' to
'h1:not(:empty), h2, h3' so tests correctly verify page content without
false-failing on the collapsed empty h1.

Also adds changeset and updated visual snapshots for the dark mode
toggle mobile fix.
@github-actions
Copy link
Copy Markdown
Contributor

✅ Visual Regression Test Results

Status: ✅ All visual tests passed!

All screenshots match the baseline. No visual regressions detected! 🎉

@perasperaactual perasperaactual merged commit 5279236 into dev May 18, 2026
14 of 15 checks passed
@perasperaactual perasperaactual deleted the docs/202605018-updates branch May 18, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant