Docs/202605018 updates#437
Conversation
❌ Visual Regression Test ResultsStatus: ❌ Visual regression tests failed Visual differences were detected! Please review:
📸 Baseline screenshots are committed to the repo for reproducible testing. |
⚡ Performance Benchmark Results✅ Build Time Benchmarks: PASSED✅ Bundle Size Benchmarks: PASSED❌ Runtime Vitals Benchmarks: FAILED📝 Note: Detailed results are available in the job logs. 🎯 Performance Budgets:
Updated: 2026-05-18T19:50:34.992Z |
♿ Accessibility Test ResultsOverall Status: ✅ 0/0 tests passed 🦮 WCAG 2.1 AA ComplianceNo WCAG test results available ⌨️ Keyboard NavigationNo keyboard navigation test results available 📊 Detailed ReportDownload the full HTML accessibility report from the workflow artifacts for:
🔍 Testing ChecklistOur accessibility tests verify:
Powered by @axe-core/playwright and Playwright |
Show dark mode toggle on narrow screens alongside the hamburger menu rather than hiding it. Toggle now renders left of the hamburger on mobile and right of nav links on desktop. Replaces one compound conditional with three intent-revealing render sites. Also updates examples/stackwright-docs/stackwright.yml.
❌ Visual Regression Test ResultsStatus: ❌ Visual regression tests failed Visual differences were detected! Please review:
📸 Baseline screenshots are committed to the repo for reproducible testing. |
The TopAppBar h1 is now intentionally empty when a wordmark logo is used. Update smoke and user-journey test selectors from 'h1, h2, h3' to 'h1:not(:empty), h2, h3' so tests correctly verify page content without false-failing on the collapsed empty h1. Also adds changeset and updated visual snapshots for the dark mode toggle mobile fix.
✅ Visual Regression Test ResultsStatus: ✅ All visual tests passed! All screenshots match the baseline. No visual regressions detected! 🎉 |
Changes in this PR
fix: dark mode toggle always visible on mobile (
TopAppBar)Previously the
colorModeTogglewas hidden on narrow screens whenever nav menu items were present, due to an overly broad conditional:Now replaced with three intent-revealing render sites:
isSmDown[🌙] [☰]!isSmDown[Link] [Link] [🌙]!menuItems || menuItems.length === 0