CLOUD-589 Pass additional Statefulset labels and any Annotations from values.yaml#78
Open
andrewkro wants to merge 5 commits into
Open
Conversation
This addition to the statefulset template and values file allows custom labels to be passed into the metadata labels block AND annotations. Our usecase for annotations is to set our vault providers (vault.security.banzaicloud.io) vault-role for permission to get any secretes required (in this case, credentials.password) CLOUD-589
|
|
andrewkro
changed the title
Add options to the readme page Add new line in values EOF and edit comment to explain labels Change auto-indenting from editor on annotations with loop CLOUD-589
tplavcic
requested changes
Mar 17, 2021
| {{- if .Values.statefulSet.podTemplate.labels }} | ||
| {{ toYaml .Values.statefulSet.podTemplate.labels | indent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.statefulSet.podTemplate.annotations }} |
Contributor
There was a problem hiding this comment.
Hi @andrewkro ! Sorry, but this got sidetracked somehow!
Could you please rebase on current main branch and the annotations for the pod will need to be changed a bit since we set annotations in case if platform is openshift so we need to merge them and not that one overrides the other values.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition to the statefulset template and values file allows custom
labels to be passed into the metadata labels block AND annotations.
Our usecase for annotations is to set our vault providers
(vault.security.banzaicloud.io) vault-role for permission to get
any secretes required (in this case, credentials.password)
CLOUD-589